GitBook: [master] 2 pages modified

christianalfoni · gitbook-bot · commit 63a979a932c3 · 2020-01-23T12:29:19.000Z
diff --git a/core/defining-state.md b/core/defining-state.md
@@ -113,6 +113,10 @@ export const state = {
 {% endtab %}
 {% endtabs %}
 
+{% hint style="warning" %}
+It is import that you do **NOT** use arrow functions on your methods. The reason is that this binds the context of the method to the instance itself, meaning that Overmind is unable to proxy access and allow you to do tracked mutations
+{% endhint %}
+
 You can now use this instance as normal and of course create new ones.
 
 {% hint style="info" %}
@@ -383,12 +387,12 @@ You set an **initial** state and then you create a relationship between the diff
 export const login = async ({ state, effects }) => {
   return state.mode.authenticating(async () => {
     try {
-      const user = await effects.api.getUser()
-      state.mode.authenticated(() => {
+      const user = effects.api.getUser()
+      return state.mode.authenticated(() => {
         state.user = user
       })
     } catch (error) {
-      state.mode.unauthenticated(() => {
+      return state.mode.unauthenticated(() => {
         state.error = error
       })    
     }
@@ -399,9 +403,9 @@ export const logout = async ({ state, effects }) => {
   return state.mode.unauthenticating(async () => {
     try {
       await effects.api.logout()
-      state.mode.unauthenticated()
+      return state.mode.unauthenticated()
     } catch (error) {
-      state.mode.authenticated(() => {
+      return state.mode.authenticated(() => {
         state.error = error
       })    
     }
@@ -411,8 +415,11 @@ export const logout = async ({ state, effects }) => {
 {% endtab %}
 {% endtabs %}
 
-{% hint style="info" %}
-If your transition runs asynchronously you should return the transition to ensure that the action execution is tracked
+{% hint style="warning" %}
+There are two important rules for predictable transitions:
+
+1. The transition should always **return**
+2. **Async** transitions should not **mutate** state
 {% endhint %}
 
 What is important to realize here is that our logic is separated into **allowable** transitions. That means when we are waiting for the user on **line 4** and some other logic has changed the state to **unauthenticated** in the meantime, the user will not be set, as the **authenticated** transition is now not possible. This is what state machines do. They group logic into states that are allowed to run, preventing invalid logic to run.
diff --git a/guides-1/server-side-rendering.md b/guides-1/server-side-rendering.md
@@ -103,55 +103,3 @@ export const onInitialize: OnInitialize = ({ state }) => {
 If you are using state first routing, make sure you prevent the router from firing off the initial route, as this is not needed.
 {% endhint %}
 
-## OnInitialize
-
-The `onInitialized` action does not run on the server. The reason is that it is considered a side effect you might not want to run, so we do not force it. If you do want to run an action as Overmind fires up both on the client and the server you can rather create a custom action for it.
-
-{% tabs %}
-{% tab title="overmind/actions.js" %}
-```javascript
-export const initialize = () => {
-  // Whatever...
-}
-```
-{% endtab %}
-
-{% tab title="client/index.js" %}
-```typescript
-import { createOvermind } from 'overmind'
-import { config } from './overmind'
-
-const overmind = createOvermind(config)
-overmind.actions.initialize()
-```
-{% endtab %}
-
-{% tab title="server/index.js" %}
-```javascript
-import { createOvermindSSR } from 'overmind'
-import { config } from '../client/overmind'
-
-export default async (req, res) => {
-  const overmind = createOvermindSSR(config)
-  await overmind.actions.initialize()
-
-  const html = renderToString(
-    // Whatever implementation your view layer provides
-  )
-
-  res.send(`
-<html>
-  <body>
-    <div id="app">${html}</div>
-    <script>
-      window.__OVERMIND_MUTATIONS = ${JSON.stringify(overmind.hydrate())}
-    </script>
-    <script src="/scripts/app.js"></script>
-  </body>
-</html>
-`)
-}
-```
-{% endtab %}
-{% endtabs %}
-
