move search icon inside search button

Author: MAX-786

docs/_static/custom.css

@@ -194,13 +194,8 @@ div.admonition.admonition-todo>.admonition-title::before {
   padding-bottom: 0;
 }
 
-#search-form .search-icon {
-  left: 1.5625rem;
-}
-
 input#q {
   border-radius: .25rem 0 0 .25rem;
-  padding-left: 2.1875rem;
 }
 
 .form-control:focus {
@@ -284,14 +279,6 @@ input#search-input {
   border-radius: .25rem 0 0 .25rem;
 }
 
-.search-icon {
-  position: absolute;
-  color: #a4a6a7;
-  left: .625rem;
-  z-index: 100;
-  align-self: center;
-}
-
 .input-group-text kbd {
   padding: 0rem 0.4rem;
   font-size: 135%;

docs/_templates/search.html

@@ -50,7 +50,6 @@ <h1 id="search-documentation">{{ _('Search') }}</h1>
         <div class="input-group col-xl-8 mb-2">
           <label for="q" class="sr-only">Search string
           </label>
-          <i class="fas fa-search fa-lg search-icon" aria-hidden="true"></i>
           <input
           type="search" name="q" id="q"
           class="form-control"
@@ -71,7 +70,7 @@ <h1 id="search-documentation">{{ _('Search') }}</h1>
             ><i class="fas fa-times"></i></button>
           </div>
           <div class="input-group-append">
-            <button type="submit" class="btn btn-primary">{{ _('search') }}</button>
+            <button type="submit" class="btn btn-primary"><i class="fas fa-search fa-lg" aria-hidden="true"></i></button>
           </div>
         </div>
       </div>