Resolve discussions (codesandbox#1987)

* Resolve SSEDownNotice discussions

* Resolve GitHub discussions

* Resolve More discussions

Author: MichaelDeBoey

packages/app/src/app/pages/Sandbox/Editor/Workspace/SSEDownNotice/SSEDownNotice.tsx

@@ -7,14 +7,18 @@ import { useStore } from 'app/store';
 import { Container } from './elements';
 
 export const SSEDownNotice = observer(() => {
-  const store = useStore();
+  const {
+    editor: {
+      currentSandbox: { template },
+    },
+    server: { status },
+  } = useStore();
 
-  const templateDef = getTemplate(store.editor.currentSandbox.template);
-  if (!templateDef.isServer) {
+  if (!getTemplate(template).isServer) {
     return null;
   }
 
-  if (store.server.status !== 'disconnected') {
+  if (status !== 'disconnected') {
     return null;
   }
 

packages/app/src/app/pages/Sandbox/Editor/Workspace/items/GitHub/Git/Git.tsx

@@ -14,9 +14,8 @@ import { WorkspaceSubtitle, WorkspaceInputContainer } from '../../../elements';
 import { Container, Buttons, ErrorMessage, NoChanges } from './elements';
 import { TotalChanges } from './TotalChanges';
 
-function hasWriteAccess(rights: 'none' | 'read' | 'write' | 'admin') {
-  return rights === 'write' || rights === 'admin';
-}
+const hasWriteAccess = (rights: 'none' | 'read' | 'write' | 'admin') =>
+  ['admin', 'write'].includes(rights);
 
 export const Git = observer(() => {
   const {

packages/app/src/app/pages/Sandbox/Editor/Workspace/items/More/More.tsx

@@ -23,7 +23,9 @@ export const More = observer<Props>(({ id, message }) => {
     editor: { isForkingSandbox },
   } = useStore();
 
-  useEffect(() => track('Workspace - More Opened', { id }), [id]);
+  useEffect(() => {
+    track('Workspace - More Opened', { id })
+  }, [id]);
 
   return (
     <div>