Skip to content

Commit f971493

Browse files
committed
Show absolute version for every version satisfying semver
1 parent ed5b466 commit f971493

File tree

1 file changed

+10
-7
lines changed
  • packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/VersionEntry

1 file changed

+10
-7
lines changed

packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/VersionEntry/index.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@ export default class VersionEntry extends React.PureComponent {
2121
}
2222

2323
componentWillMount() {
24-
if (this.props.dependencies[this.props.dependency] === 'latest') {
25-
this.setVersionsForLatestPkg(`${this.props.dependency}@latest`);
24+
const versionRegex = /^\d{1,3}\.\d{1,3}.\d{1,3}$/;
25+
const version = this.props.dependencies[this.props.dependency];
26+
if (!versionRegex.test(version)) {
27+
this.setVersionsForLatestPkg(`${this.props.dependency}@${version}`);
2628
}
2729
}
2830

@@ -45,10 +47,7 @@ export default class VersionEntry extends React.PureComponent {
4547

4648
render() {
4749
const { dependencies, dependency } = this.props;
48-
const version =
49-
dependencies[dependency] === 'latest' && this.state.version
50-
? `latest (${this.state.version})`
51-
: dependencies[dependency];
50+
5251
const { hovering } = this.state;
5352
return (
5453
<EntryContainer
@@ -58,7 +57,11 @@ export default class VersionEntry extends React.PureComponent {
5857
<Link href={`https://www.npmjs.com/package/${dependency}`}>
5958
{dependency}
6059
</Link>
61-
<Version hovering={hovering}>{version}</Version>
60+
<Version hovering={hovering}>
61+
{dependencies[dependency]}{' '}
62+
{hovering &&
63+
this.state.version && <span>({this.state.version})</span>}
64+
</Version>
6265
{hovering && (
6366
<IconArea>
6467
<Icon onClick={this.handleRefresh}>

0 commit comments

Comments
 (0)