Skip to content

Commit f91f152

Browse files
authored
Default to vertical layout when height > width (codesandbox#1306)
* Default to vertical layout when height > width * Update snapshots
1 parent dff7686 commit f91f152

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

packages/app/src/embed/components/App/index.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export default class App extends React.PureComponent<{}, State> {
7878
forceRefresh,
7979
expandDevTools,
8080
runOnClick,
81-
verticalMode,
81+
verticalMode = window.innerWidth < window.innerHeight,
8282
} = getSandboxOptions(document.location.href);
8383

8484
this.state = {
@@ -199,7 +199,9 @@ export default class App extends React.PureComponent<{}, State> {
199199
<Centered vertical horizontal>
200200
<Title delay={0.1}>Not Found</Title>
201201
<SubTitle delay={0.05}>
202-
We could not find the sandbox you{"'"}re looking for.
202+
We could not find the sandbox you
203+
{"'"}
204+
re looking for.
203205
</SubTitle>
204206
</Centered>
205207
);

packages/common/__snapshots__/url.test.js.snap

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ Object {
1616
"isTestPreviewWindow": false,
1717
"runOnClick": undefined,
1818
"useCodeMirror": false,
19-
"verticalMode": false,
2019
}
2120
`;
2221

@@ -37,7 +36,6 @@ Object {
3736
"isTestPreviewWindow": false,
3837
"runOnClick": undefined,
3938
"useCodeMirror": false,
40-
"verticalMode": false,
4139
}
4240
`;
4341

@@ -57,7 +55,6 @@ Object {
5755
"isTestPreviewWindow": false,
5856
"runOnClick": undefined,
5957
"useCodeMirror": false,
60-
"verticalMode": false,
6158
}
6259
`;
6360

@@ -77,7 +74,6 @@ Object {
7774
"isTestPreviewWindow": false,
7875
"runOnClick": undefined,
7976
"useCodeMirror": false,
80-
"verticalMode": false,
8177
}
8278
`;
8379

@@ -97,7 +93,6 @@ Object {
9793
"isTestPreviewWindow": false,
9894
"runOnClick": undefined,
9995
"useCodeMirror": false,
100-
"verticalMode": false,
10196
}
10297
`;
10398

@@ -118,7 +113,6 @@ Object {
118113
"isTestPreviewWindow": false,
119114
"runOnClick": undefined,
120115
"useCodeMirror": false,
121-
"verticalMode": false,
122116
}
123117
`;
124118

@@ -138,7 +132,6 @@ Object {
138132
"isTestPreviewWindow": false,
139133
"runOnClick": undefined,
140134
"useCodeMirror": false,
141-
"verticalMode": false,
142135
}
143136
`;
144137

@@ -158,6 +151,5 @@ Object {
158151
"isTestPreviewWindow": false,
159152
"runOnClick": undefined,
160153
"useCodeMirror": false,
161-
"verticalMode": false,
162154
}
163155
`;

packages/common/url.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,10 @@ export const getSandboxOptions = (url: string) => {
6767
result.enableEslint = url.includes('eslint=1');
6868
result.forceRefresh = url.includes('forcerefresh=1');
6969
result.expandDevTools = url.includes('expanddevtools=1');
70-
result.verticalMode = url.includes('verticallayout=1');
70+
if (url.includes('verticallayout=')) {
71+
result.verticalMode = url.includes('verticallayout=1');
72+
}
73+
console.log(result);
7174
result.runOnClick = url.includes('runonclick=0')
7275
? false
7376
: url.includes('runonclick=1')

0 commit comments

Comments
 (0)