merge

Author: christianalfoni

.all-contributorsrc

@@ -1,11 +1,13 @@
 {
   "projectName": "codesandbox-client",
   "projectOwner": "codesandbox",
+  "repoType": "github",
+  "repoHost": "https://github.com",
   "files": [
     "README.md"
   ],
   "imageSize": 100,
-  "commit": true,
+  "commit": false,
   "contributors": [
     {
       "login": "CompuIves",
@@ -1347,9 +1349,99 @@
       "contributions": [
         "code"
       ]
+    },
+    {
+      "login": "Shriram-Balaji",
+      "name": "Shriram Balaji",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/11358903?v=4",
+      "profile": "https://shriram-balaji.github.io",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "chinmay17",
+      "name": "Chinmay Chaudhary",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/7131231?v=4",
+      "profile": "https://github.com/chinmay17",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "sakthivel",
+      "name": "Sakthivel Sengodan Sapient",
+      "avatar_url": "https://avatars3.githubusercontent.com/u/205201?v=4",
+      "profile": "https://github.com/Sakthivel",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "vanya829",
+      "name": "vanya829",
+      "avatar_url": "https://avatars0.githubusercontent.com/u/1397979?v=4",
+      "profile": "https://github.com/vanya829",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "hetpatel33",
+      "name": "Het Patel",
+      "avatar_url": "https://avatars0.githubusercontent.com/u/13877514?v=4",
+      "profile": "http://hetpatel33.github.io",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "Gobinath-Manokaran",
+      "name": "Gobinath-Manokaran",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/6711914?v=4",
+      "profile": "https://github.com/Gobinath-Manokaran",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "armujahid",
+      "name": "Abdul Rauf",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/3725386?v=4",
+      "profile": "https://armujahid.me",
+      "contributions": [
+        "code",
+        "doc"
+      ]
+    },
+    {
+      "login": "milap1296",
+      "name": "milap1296",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/19545730?v=4",
+      "profile": "https://github.com/milap1296",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "yevhenorlov",
+      "name": "yevhen orlov",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/17388747?v=4",
+      "profile": "http://yevhenorlov.com",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "NileshPatel17",
+      "name": "Nilesh Patel",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/27020381?v=4",
+      "profile": "https://github.com/NileshPatel17",
+      "contributions": [
+        "code"
+      ]
     }
   ],
-  "repoType": "github",
-  "repoHost": "https://github.com",
-  "contributorsPerLine": 7
+  "contributorsPerLine": 7,
+  "commitConvention": "none"
 }

.circleci/config.yml

@@ -279,6 +279,7 @@ jobs:
       - build_prod
   test-integrations:
     executor: node-with-puppeteer
+    parallelism: 2
     steps:
       - checkout_with_cache
       - test_integrations

.drone.yml

@@ -1,61 +1,46 @@
 ---
 kind: pipeline
-name: default
+name: pull_request
 
 steps:
   - name: restore node_modules cache
-    image: codesandbox-cache:1
+    image: lbogdan/codesandbox-cache-plugin:1
     settings:
       restore: true
     volumes:
       - name: node_modules-cache
         path: /cache
-    when:
-      event:
-        - pull_request
 
   - name: install packages
-    image: node:10.15.3-jessie
+    image: node:10.16.3-jessie
     volumes:
       - name: yarn-cache
         path: /usr/local/share/.cache/yarn/v4
     commands:
       - yarn
-    when:
-      event:
-        - pull_request
 
   - name: build
-    image: node:10.15.3-jessie
+    image: node:10.16.3-jessie
     commands:
       - export STAGING_BRANCH=pr$DRONE_PULL_REQUEST
       - yarn build
-    when:
-      event:
-        - pull_request
 
   - name: deploy
-    image: codesandbox-deploy:1
+    image: lbogdan/codesandbox-deploy-plugin:2
     settings:
       domain: &domain build.csb.dev
     volumes:
       - name: docker_sock
         path: /var/run/docker.sock
       - name: deployments
         path: /root/docker/deployments
-    when:
-      event:
-        - pull_request
 
   - name: create github deployment
-    image: codesandbox-github-deployment:1
+    image: lbogdan/github-deployment-plugin:1
     settings:
       domain: *domain
       github_token:
         from_secret: github_token
-    when:
-      event:
-        - pull_request
 
   - name: slack notification
     image: plugins/slack
@@ -70,22 +55,108 @@ steps:
           👎 {{repo.owner}}/{{repo.name}} pull request #{{build.pull}} building failed. See what happened <{{build.link}}|here>.
         {{/success}}
     when:
-      event:
-        - pull_request
+      status:
+        - success
+        - failure
+
+  - name: github comment
+    image: lbogdan/github-comment-plugin:1
+    settings:
+      domain: *domain
+      github_token:
+        from_secret: github_token
+      template: |
+        Build for latest commit https://github.com/{{owner}}/{{repo}}/pull/{{pr}}/commits/{{commitSha}} {{#success}}is at https://pr{{pr}}.{{buildDomain}}/s/new{{/success}}{{^success}}failed{{/success}}.
+    when:
       status:
         - success
         - failure
 
   - name: rebuild node_modules cache
-    image: codesandbox-cache:1
+    image: lbogdan/codesandbox-cache-plugin:1
     settings:
       rebuild: true
     volumes:
       - name: node_modules-cache
         path: /cache
+
+volumes:
+  - name: yarn-cache
+    host:
+      path: /var/lib/docker/volumes/yarn-cache/_data
+  - name: node_modules-cache
+    host:
+      path: /var/lib/docker/volumes/node_modules-cache/_data
+  - name: docker_sock
+    host:
+      path: /var/run/docker.sock
+  - name: deployments
+    host:
+      path: /root/docker/deployments
+
+trigger:
+  event: pull_request
+---
+kind: pipeline
+name: branch
+
+steps:
+  - name: restore node_modules cache
+    image: lbogdan/codesandbox-cache-plugin:1
+    settings:
+      restore: true
+    volumes:
+      - name: node_modules-cache
+        path: /cache
+
+  - name: install packages
+    image: node:10.16.3-jessie
+    volumes:
+      - name: yarn-cache
+        path: /usr/local/share/.cache/yarn/v4
+    commands:
+      - yarn
+
+  - name: build
+    image: node:10.16.3-jessie
+    commands:
+      - export STAGING_BRANCH=$DRONE_BRANCH
+      - yarn build
+
+  - name: deploy
+    image: lbogdan/codesandbox-deploy-plugin:2
+    settings:
+      domain: &domain build.csb.dev
+    volumes:
+      - name: docker_sock
+        path: /var/run/docker.sock
+      - name: deployments
+        path: /root/docker/deployments
+
+  - name: slack notification
+    image: plugins/slack
+    settings:
+      webhook:
+        from_secret: slack_webhook
+      channel: infra
+      template: >
+        {{#success build.status}}
+          👍 {{repo.owner}}/{{repo.name}} branch {{build.branch}} successfully built. Access it at https://{{build.branch}}.build.csb.dev/ and see the build logs <{{build.link}}|here>.
+        {{else}}
+          👎 {{repo.owner}}/{{repo.name}} branch {{build.branch}} building failed. See what happened <{{build.link}}|here>.
+        {{/success}}
     when:
-      event:
-        - pull_request
+      status:
+        - success
+        - failure
+
+  - name: rebuild node_modules cache
+    image: lbogdan/codesandbox-cache-plugin:1
+    settings:
+      rebuild: true
+    volumes:
+      - name: node_modules-cache
+        path: /cache
 
 volumes:
   - name: yarn-cache
@@ -100,8 +171,12 @@ volumes:
   - name: deployments
     host:
       path: /root/docker/deployments
+
+trigger:
+  event: push
+  branch: master
 ---
 kind: signature
-hmac: 4d9c06dbed6f93871c3a0bb5b80b35e353d8a5254d84ba07c0fb14e4f6ea9ecd
+hmac: 015a8ddaa2fa145808e3c30ad05da71d03e3b8653b6bddb41547f13611397070
 
 ...

.eslintrc

@@ -61,6 +61,7 @@
         "js": "never"
       }
     ],
+    "import/default": "error",
     "no-param-reassign": ["error", { "props": false }],
     "camelcase": 0,
     "react-hooks/rules-of-hooks": "error",

.github/PULL_REQUEST_TEMPLATE.md

@@ -18,9 +18,11 @@ merge of your pull request!
 
 <!-- if this is a feature change -->
 
-## What steps did you take to test this?
+## What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
 
-<!-- Most important part!  -->
+1. Step A
+2. Step B
+3. Step C
 
 ## Checklist
 
@@ -30,8 +32,10 @@ merge of your pull request!
 
 - [ ] Documentation
 - [ ] Testing <!-- We can only merge the PR if this is checked -->
-- [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
-- [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->
+- [ ] Ready to be merged
+      <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
+- [ ] Added myself to contributors table
+      <!-- this is optional, see the contributing guidelines for instructions -->
 
 <!-- feel free to add additional comments -->
 <!-- Thank you for contributing! -->

.yarnclean

@@ -9,7 +9,6 @@ docs
 doc
 website
 images
-assets
 
 # examples
 example

CONTRIBUTING.md

@@ -64,6 +64,7 @@ To install the project you need to have `yarn` and `node`
     - you can use [fnm](https://github.com/Schniz/fnm) (`fnm use`) to change
       your current node version to the one specified in `.nvmrc`
 3.  from the root of the project: `yarn` to install all dependencies
+    - make sure you have latest `yarn` version
 4.  from the root of the project: `yarn start`
     - this builds the dependencies (`codesandbox-api` and
       `codesandbox-browserfs`) and runs the `app` development environment,
@@ -125,9 +126,9 @@ To add yourself to the table of contributors on the `README.md`, please use the
 automated script as part of your PR:
 
 ```sh
-yarn add-contributor
+yarn contributors:add
 ```
 
 Follow the prompt and commit `.all-contributorsrc` and `README.md` in the PR.
 
-Thank you for taking the time to contribute! :+1:
+Thank you for taking the time to contribute! 👍