fix typings and smoother module selection

Author: christianalfoni

packages/app/src/app/overmind/effects/vscode/index.ts

@@ -303,16 +303,19 @@ export class VSCodeEffect {
   public async openModule(module: Module) {
     await this.initialized;
 
-    try {
-      const model = await this.modelsHandler.changeModule(module);
-
-      this.lint(module.title, model);
-    } catch (error) {
-      // We might try to open a module that is not actually opened in the editor,
-      // but the configuration wizard.. currently this throws an error as there
-      // is really no good way to identify when it happen. This needs to be
-      // improved in next version
-    }
+    // We open this on the next tick to allow a UI update to occur first
+    setTimeout(async () => {
+      try {
+        const model = await this.modelsHandler.changeModule(module);
+
+        this.lint(module.title, model);
+      } catch (error) {
+        // We might try to open a module that is not actually opened in the editor,
+        // but the configuration wizard.. currently this throws an error as there
+        // is really no good way to identify when it happen. This needs to be
+        // improved in next version
+      }
+    });
   }
 
   setErrors = (errors: ModuleError[]) => {

packages/app/src/app/overmind/internalActions.ts

@@ -317,7 +317,7 @@ export const ensurePackageJSON: AsyncAction = async ({ state, effects }) => {
     // We grab the module from the state to continue working with it (proxy)
     const module = sandbox.modules[sandbox.modules.length - 1];
 
-    effects.vscode.fs.writeFile(state.editor.modulesByPath, module);
+    effects.vscode.sandboxFsSync.writeFile(state.editor.modulesByPath, module);
 
     try {
       const updatedModule = await effects.api.createModule(sandbox.id, module);
@@ -326,7 +326,7 @@ export const ensurePackageJSON: AsyncAction = async ({ state, effects }) => {
       module.shortid = updatedModule.shortid;
     } catch (error) {
       sandbox.modules.splice(sandbox.modules.indexOf(module), 1);
-      state.editor.modulesByPath = effects.vscode.fs.create(sandbox);
+      state.editor.modulesByPath = effects.vscode.sandboxFsSync.create(sandbox);
     }
   }
 };

packages/app/src/app/overmind/namespaces/live/actions.ts

@@ -28,10 +28,10 @@ export const roomJoined: AsyncAction<{
 
   state.workspace.openedWorkspaceItem = defaultItem.id;
 
-  state.editor.modulesByPath = await effects.vscode.changeSandbox(
-    state.editor.currentSandbox
-  );
-  effects.vscode.syncTypings();
+  await effects.vscode.changeSandbox(state.editor.currentSandbox, fs => {
+    state.editor.modulesByPath = fs;
+  });
+
   effects.vscode.openModule(state.editor.currentModule);
   effects.preview.executeCodeImmediately(true);
   state.live.isLoading = false;
@@ -48,9 +48,9 @@ export const createLiveClicked: AsyncAction<{
   const sandbox = await actions.live.internal.initialize(roomId);
   actions.internal.setCurrentSandbox(sandbox);
 
-  state.editor.modulesByPath = await effects.vscode.changeSandbox(
-    state.editor.currentSandbox
-  );
+  await effects.vscode.changeSandbox(state.editor.currentSandbox, fs => {
+    state.editor.modulesByPath = fs;
+  });
 
   effects.vscode.openModule(state.editor.currentModule);
   effects.preview.executeCodeImmediately(true);