Skip to content

Commit ef547c3

Browse files
fix wrong mutation when creating live (codesandbox#3709)
* fix wrong mutation when creating live * Remove double render of preview Co-authored-by: Ives van Hoorne <[email protected]>
1 parent ee1a9a6 commit ef547c3

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

packages/app/src/app/overmind/namespaces/editor/actions.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ export const sandboxChanged: AsyncAction<{ id: string }> = withLoadApp<{
201201
}
202202

203203
effects.vscode.openModule(state.editor.currentModule);
204-
effects.preview.executeCodeImmediately({ initialRender: true });
205204

206205
if (COMMENTS) {
207206
try {

packages/app/src/app/overmind/namespaces/live/actions.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ export const onOperationError: Action<{
3939
return;
4040
}
4141

42-
if (code !== undefined) {
43-
module.code = code;
44-
}
45-
if (saved_code !== undefined) {
46-
module.savedCode = saved_code;
47-
}
42+
if (code !== undefined) {
43+
module.code = code;
44+
}
45+
if (saved_code !== undefined) {
46+
module.savedCode = saved_code;
47+
}
4848

4949
effects.vscode.setModuleCode(module);
5050
};
@@ -88,7 +88,6 @@ export const roomJoined: AsyncAction<{
8888

8989
effects.live.sendModuleStateSyncRequest();
9090
effects.vscode.openModule(state.editor.currentModule);
91-
effects.preview.executeCodeImmediately({ initialRender: true });
9291
state.editor.isLoading = false;
9392
});
9493

@@ -118,8 +117,6 @@ export const createLiveClicked: AsyncAction<string> = async (
118117
};
119118
}),
120119
});
121-
122-
Object.assign(state.editor.sandboxes[sandboxId], sandbox);
123120
state.editor.modulesByPath = effects.vscode.sandboxFsSync.create(sandbox);
124121

125122
effects.live.sendModuleStateSyncRequest();

0 commit comments

Comments
 (0)