not fixed, need to control the initial bootup of extension host, but no idea how

Author: christianalfoni

packages/app/src/app/overmind/effects/vscode/index.ts

@@ -103,6 +103,7 @@ export class VSCodeEffect {
   public initialized: Promise<unknown>;
   public sandboxFsSync: SandboxFsSync;
   private mountableFilesystem: any;
+  private isRunningExtensionHost = true;
 
   private monaco: any;
   private editorApi: any;
@@ -468,14 +469,31 @@ export class VSCodeEffect {
 
     setFs(this.sandboxFsSync.create(sandbox));
 
-    if (isFirstLoad) {
-      this.sandboxFsSync.sync(() => {});
-    } else {
-      this.editorApi.extensionService.stopExtensionHost();
-      this.sandboxFsSync.sync(() => {
-        this.editorApi.extensionService.startExtensionHost();
-      });
+    return new Promise(resolve => {
+      if (isFirstLoad) {
+        // Do no start extension host
+        this.sandboxFsSync.sync(resolve);
+      } else {
+        this.stopExtensionHost();
+        this.sandboxFsSync.sync(resolve);
+      }
+    });
+  }
+
+  public startExtensionHost() {
+    if (this.isRunningExtensionHost) {
+      return;
+    }
+    this.editorApi.extensionService.startExtensionHost();
+    this.isRunningExtensionHost = true;
+  }
+
+  public stopExtensionHost() {
+    if (!this.isRunningExtensionHost) {
+      return;
     }
+    this.editorApi.extensionService.stopExtensionHost();
+    this.isRunningExtensionHost = false;
   }
 
   public async setModuleCode(module: Module) {

packages/app/src/app/overmind/namespaces/editor/actions.ts

@@ -1,14 +1,13 @@
-import { debounce } from 'lodash-es';
 import { resolveModule } from '@codesandbox/common/lib/sandbox/modules';
 import getTemplate from '@codesandbox/common/lib/templates';
 import {
   EnvironmentVariable,
+  Module,
   ModuleCorrection,
   ModuleError,
   ModuleTab,
-  WindowOrientation,
-  Module,
   UserSelection,
+  WindowOrientation,
 } from '@codesandbox/common/lib/types';
 import { logBreadcrumb } from '@codesandbox/common/lib/utils/analytics/sentry';
 import { getTextOperation } from '@codesandbox/common/lib/utils/diff';
@@ -24,6 +23,7 @@ import {
 } from 'app/graphql/types';
 import { Action, AsyncAction } from 'app/overmind';
 import { withLoadApp, withOwnedSandbox } from 'app/overmind/factories';
+import { getSavedCode } from 'app/overmind/utils/sandbox';
 import {
   addDevToolsTab as addDevToolsTabUtil,
   closeDevToolsTab as closeDevToolsTabUtil,
@@ -32,7 +32,7 @@ import {
 import { convertAuthorizationToPermissionType } from 'app/utils/authorization';
 import { clearCorrectionsFromAction } from 'app/utils/corrections';
 import history from 'app/utils/history';
-import { getSavedCode } from 'app/overmind/utils/sandbox';
+import { debounce } from 'lodash-es';
 import { Selection, TextOperation } from 'ot';
 import { json } from 'overmind';
 
@@ -239,6 +239,12 @@ export const sandboxChanged: AsyncAction<{ id: string }> = withLoadApp<{
     state.editor.modulesByPath = fs;
   });
 
+  if (sandbox.featureFlags?.containerLsp) {
+    effects.vscode.stopExtensionHost();
+  } else {
+    effects.vscode.startExtensionHost();
+  }
+
   if (sandbox.featureFlags?.containerLsp && !sandbox.owned) {
     effects.vscode.setReadOnly(true);
     effects.notificationToast.add({

packages/app/src/app/overmind/namespaces/live/actions.ts

@@ -1,8 +1,8 @@
 import {
   LiveMessage,
   LiveMessageEvent,
-  UserViewRange,
   UserSelection,
+  UserViewRange,
 } from '@codesandbox/common/lib/types';
 import { Action, AsyncAction, Operator } from 'app/overmind';
 import { withLoadApp } from 'app/overmind/factories';
@@ -77,6 +77,8 @@ export const roomJoined: AsyncAction<{
     state.editor.modulesByPath = fs;
   });
 
+  effects.vscode.startExtensionHost();
+
   effects.live.sendModuleStateSyncRequest();
   effects.vscode.openModule(state.editor.currentModule);
   state.editor.isLoading = false;

packages/app/src/app/overmind/namespaces/server/actions.ts

@@ -18,12 +18,15 @@ export const restartContainer: Action = ({ state, effects }) => {
   effects.executor.emit('sandbox:restart-container');
 };
 
-export const statusChanged: Action<ServerStatus> = ({ state }, status) => {
+export const statusChanged: Action<ServerStatus> = (
+  { state, effects },
+  status
+) => {
   state.server.status = status;
 };
 
 export const containerStatusChanged: Action<ServerContainerStatus> = (
-  { state },
+  { state, actions },
   status
 ) => {
   state.server.containerStatus = status;
@@ -45,14 +48,17 @@ export const onSSEMessage: Action<{
       ) {
         server.status = ServerStatus.DISCONNECTED;
         effects.codesandboxApi.disconnectSSE();
+        effects.vscode.stopExtensionHost();
       }
       break;
     case 'sandbox:start':
       server.containerStatus = ServerContainerStatus.SANDBOX_STARTED;
+      effects.vscode.startExtensionHost();
       break;
     case 'sandbox:stop':
       if (server.containerStatus !== ServerContainerStatus.HIBERNATED) {
         server.containerStatus = ServerContainerStatus.STOPPED;
+        effects.vscode.stopExtensionHost();
       }
       break;
     case 'sandbox:update':
@@ -61,12 +67,14 @@ export const onSSEMessage: Action<{
     case 'sandbox:hibernate':
       server.containerStatus = ServerContainerStatus.HIBERNATED;
       effects.executor.closeExecutor();
+      effects.vscode.stopExtensionHost();
       break;
     case 'sandbox:status':
       if (data.status === 'starting-container') {
         server.containerStatus = ServerContainerStatus.INITIALIZING;
       } else if (data.status === 'installing-packages') {
         server.containerStatus = ServerContainerStatus.CONTAINER_STARTED;
+        effects.vscode.startExtensionHost();
       }
       break;
     case 'sandbox:log':