Validate module saving compared to server

Author: Ives van Hoorne

src/app/store/entities/sandboxes/actions/files.js

@@ -2,6 +2,7 @@
 import { values } from 'lodash';
 
 import type { Module, Directory } from 'common/types';
+import logError from 'app/utils/error';
 
 import { createAPIActions, doRequest } from '../../../api/actions';
 import moduleEntity from '../modules/entity';
@@ -391,7 +392,7 @@ const saveModuleCode = (id: string, moduleId: string) => async (
   dispatch(moduleActions.setCode(newModule.id, module.code));
 
   try {
-    await dispatch(
+    const { data } = await dispatch(
       doRequest(
         SAVE_MODULE_CODE_API_ACTIONS,
         `sandboxes/${sandboxId}/modules/${module.shortid}`,
@@ -401,14 +402,33 @@ const saveModuleCode = (id: string, moduleId: string) => async (
         },
       ),
     );
-    dispatch(moduleActions.setModuleSynced(newModule.id));
+
+    if (data.code !== newModule.code) {
+      dispatch(
+        notificationActions.addNotification(
+          'Something went wrong while saving the module, please try again.',
+          'error',
+        ),
+      );
+
+      logError(
+        new Error(
+          `Saving module went wrong, mismatch:\n\n${data.code}\n\nvs\n\n ${newModule.code}`,
+        ),
+      );
+    } else {
+      dispatch(moduleActions.setModuleSynced(newModule.id));
+    }
+    return data;
   } catch (e) {
     dispatch(
       notificationActions.addNotification(
         'Could not save the module, please try again.',
         'error',
       ),
     );
+    e.message = `Could not save module: ${e.message}`;
+    logError(e);
   }
 };
 /**
@@ -439,7 +459,7 @@ const massUpdateModules = (id: string) => async (
         },
       ),
     );
-
+    // TODO validate return values from server
     modulesNotInSyncInSandbox.forEach(m =>
       dispatch(moduleActions.setModuleSynced(m.id)),
     );

src/app/store/entities/sandboxes/modules/actions.js

@@ -16,11 +16,11 @@ export default {
     id,
     directoryShortid,
   }),
-  setCode: (id: string, code: string) => ({
+  setCode: (id: string, code: string, isNotSynced = true) => ({
     type: SET_CODE,
     id,
     code,
-    isNotSynced: true,
+    isNotSynced,
   }),
   setModuleSynced: (id: string) => ({
     type: SET_MODULE_SYNCED,