Skip to content

Commit e6e9016

Browse files
lbogdanCompuIves
authored andcommitted
Fix error overlay closing and make it translucent (codesandbox#768)
* Fixed error overlay closing and made it translucent. * Make unmounting true by default
1 parent e96c11c commit e6e9016

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/app/src/sandbox/react-error-overlay/overlay.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ function disposeCurrentView(force: boolean) {
162162
additionalReference = null;
163163
}
164164

165-
function unmount(force: boolean = false) {
165+
function unmount(force: boolean = true) {
166166
disposeCurrentView(force);
167167
drainErrors();
168168
errorReferences = [];

packages/app/src/sandbox/react-error-overlay/styles.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const black = '#293238',
1515
lightRed = '#fccfcf',
1616
yellow = '#fbf5b4',
1717
yellowTransparent = 'rgba(251, 245, 180, 0.3)',
18-
white = '#F4F4F4';
18+
whiteTranslucent = 'rgba(244, 244, 244, 0.9)';
1919

2020
const iframeStyle = {
2121
position: 'fixed',
@@ -32,7 +32,7 @@ const overlayStyle = {
3232
height: '100%',
3333
'box-sizing': 'border-box',
3434
'text-align': 'center',
35-
'background-color': white,
35+
'background-color': whiteTranslucent,
3636
'-webkit-font-smoothing': 'antialiased',
3737
'-moz-font-smoothing': 'antialiased',
3838
'-moz-osx-font-smoothing': 'grayscale',

0 commit comments

Comments
 (0)