Skip to content

Commit cfffb59

Browse files
committed
Dynamically download correct version when multiple versions are available
Fixes codesandbox#1381
1 parent 32913b7 commit cfffb59

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

packages/app/src/sandbox/eval/npm/fetch-npm-module.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import DependencyNotFoundError from 'sandbox-hooks/errors/dependency-not-found-e
55

66
import type { Module } from '../entities/module';
77
import Manager from '../manager';
8-
import type { Manifest } from '../manager';
98

109
import getDependencyName from '../utils/get-dependency-name';
1110
import { packageFilter } from '../utils/resolve-utils';
@@ -169,7 +168,7 @@ function resolvePath(
169168
currentTModule.dependencies.add(tModule);
170169
return callback(null, tModule.module.code);
171170
} catch (e) {
172-
const depPath = p.replace('/node_modules/', '');
171+
const depPath = p.replace(/.*\/node_modules\//, '');
173172
const depName = getDependencyName(depPath);
174173

175174
// To prevent infinite loops we keep track of which dependencies have been requested before.
@@ -182,7 +181,7 @@ function resolvePath(
182181

183182
// eslint-disable-next-line
184183
const subDepVersionVersionInfo = await findDependencyVersion(
185-
currentPath,
184+
currentTModule,
186185
manager,
187186
defaultExtensions,
188187
depName

0 commit comments

Comments
 (0)