Fix transient dependency resolving for csb packages

Author: CompuIves

packages/app/src/sandbox/eval/npm/fetch-npm-module.ts

@@ -395,6 +395,19 @@ async function getDependencyVersion(
       manager.transpiledModules[foundPackageJSONPath].module.code;
     const { version } = JSON.parse(packageJSON);
 
+    const savedDepDep = manifest.dependencyDependencies[dependencyName];
+
+    if (
+      savedDepDep &&
+      savedDepDep.resolved === version &&
+      savedDepDep.semver.startsWith('https://')
+    ) {
+      return {
+        packageJSONPath: foundPackageJSONPath,
+        version: savedDepDep.semver,
+      };
+    }
+
     if (packageJSON !== '//empty.js') {
       return { packageJSONPath: foundPackageJSONPath, version };
     }
@@ -405,7 +418,15 @@ async function getDependencyVersion(
   let version = null;
 
   if (manifest.dependencyDependencies[dependencyName]) {
-    version = manifest.dependencyDependencies[dependencyName].resolved;
+    if (
+      manifest.dependencyDependencies[dependencyName].semver.startsWith(
+        'https://'
+      )
+    ) {
+      version = manifest.dependencyDependencies[dependencyName].semver;
+    } else {
+      version = manifest.dependencyDependencies[dependencyName].resolved;
+    }
   } else {
     const dep = manifest.dependencies.find(m => m.name === dependencyName);
 

packages/app/src/sandbox/version-resolving/index.ts

@@ -11,9 +11,14 @@ export async function getDependencyVersions(
 ) {
   const parsedResolutions = parseResolutions(resolutions);
 
+  const depsWithNodeLibs = { 'node-libs-browser': '2.2.0', ...dependencies };
   const depInfos = await Promise.all(
-    Object.keys(dependencies).map(depName =>
-      resolveDependencyInfo(depName, dependencies[depName], parsedResolutions)
+    Object.keys(depsWithNodeLibs).map(depName =>
+      resolveDependencyInfo(
+        depName,
+        depsWithNodeLibs[depName],
+        parsedResolutions
+      )
     )
   );