Improve dynamic downloading by prefetching package.json

Author: CompuIves

packages/app/src/sandbox/eval/npm/fetch-npm-module.ts

@@ -300,10 +300,10 @@ async function findDependencyVersion(
     const packageJSON =
       manager.transpiledModules[foundPackageJSONPath] &&
       manager.transpiledModules[foundPackageJSONPath].module.code;
-    const { version, name } = JSON.parse(packageJSON);
+    const { version } = JSON.parse(packageJSON);
 
     if (packageJSON !== '//empty.js') {
-      return { packageJSONPath: foundPackageJSONPath, version, name };
+      return { packageJSONPath: foundPackageJSONPath, version };
     }
   } catch (e) {
     /* do nothing */

…p/src/sandbox/version-resolving/index.js …p/src/sandbox/version-resolving/index.tspackages/app/src/sandbox/version-resolving/index.js renamed to packages/app/src/sandbox/version-resolving/index.ts packages/app/src/sandbox/version-resolving/index.js renamed to packages/app/src/sandbox/version-resolving/index.ts

@@ -1,7 +1,9 @@
 import { resolveDependencyInfo } from './resolve-dependency';
 import { mergeDependencies } from './merge-dependency';
 
-export async function getDependencyVersions(dependencies) {
+export async function getDependencyVersions(dependencies: {
+  [depName: string]: string;
+}) {
   const depInfos = await Promise.all(
     Object.keys(dependencies).map(depName =>
       resolveDependencyInfo(depName, dependencies[depName])

packages/app/src/sandbox/version-resolving/merge-dependency.ts

@@ -1,9 +1,9 @@
 import { uniq } from 'lodash-es';
 import * as semver from 'semver';
 
-interface ILambdaResponse {
+export interface ILambdaResponse {
   contents: {
-    [path: string]: string;
+    [path: string]: { content: string };
   };
   dependency: {
     name: string;
@@ -35,7 +35,7 @@ interface IDepDepInfo {
 }
 
 interface IResponse {
-  contents: { [path: string]: string };
+  contents: { [path: string]: { content: string } };
   dependencies: Array<{ name: string; version: string }>;
   dependencyAliases: { [dep: string]: { [dep: string]: string } };
   dependencyDependencies: {

packages/app/src/sandbox/version-resolving/resolve-dependency.ts

@@ -1,4 +1,5 @@
 import Cache from 'lru-cache';
+import { ILambdaResponse } from './merge-dependency';
 
 const packageJSONCache: Cache.Cache<string, Promise<any>> = new Cache({
   max: 100,
@@ -73,34 +74,30 @@ async function getDependencyDependencies(
   return peerDependencyResult;
 }
 
-interface IResponse {
-  contents: {};
-  dependency: {
-    name: string;
-    version: string;
-  };
-  peerDependencies: { [name: string]: string };
-  dependencyDependencies: IPeerDependencyResult;
-}
-
 export async function resolveDependencyInfo(dep: string, version: string) {
-  const response: IResponse = {
+  const packageJSON = await getPackageJSON(dep, version);
+  const response: ILambdaResponse = {
     contents: {},
     dependency: {
       name: dep,
-      version,
+      version: packageJSON.version,
     },
     peerDependencies: {},
     dependencyDependencies: {},
+    dependencyAliases: {},
   };
 
-  const packageJSON = await getPackageJSON(dep, version);
   response.peerDependencies = packageJSON.peerDependencies;
-
   response.dependencyDependencies = await getDependencyDependencies(
     dep,
     version
   );
 
+  response.contents = {
+    [`/node_modules/${dep}/package.json`]: {
+      content: JSON.stringify(packageJSON, null, 2),
+    },
+  };
+
   return response;
 }