Skip to content

Commit b778a2d

Browse files
committed
Progress
1 parent 225cfc5 commit b778a2d

File tree

3 files changed

+33
-13
lines changed

3 files changed

+33
-13
lines changed

packages/app/src/app/components/CodeEditor/VSCode/MonacoReactComponent.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ class MonacoEditor extends React.PureComponent {
142142
{ ICodeEditorService },
143143
{ ITextFileService },
144144
{ CodeSandboxRequestService },
145+
{ ILifecycleService, LifecyclePhase },
145146
] = [
146147
r('vs/codesandbox/commandService'),
147148
r('vs/codesandbox/hashService'),
@@ -191,8 +192,11 @@ class MonacoEditor extends React.PureComponent {
191192
r('vs/editor/browser/services/codeEditorService'),
192193
r('vs/workbench/services/textfile/common/textfiles'),
193194
r('vs/codesandbox/requestService'),
195+
r('vs/platform/lifecycle/common/lifecycle'),
194196
];
195197

198+
document.body.className += ' vs-dark';
199+
196200
const container = document.createElement('div');
197201
const part = document.createElement('div');
198202

@@ -286,6 +290,12 @@ class MonacoEditor extends React.PureComponent {
286290
const textFileService = services.get(ITextFileService);
287291
const editorService = services.get(IEditorService);
288292

293+
const lifecycleService = services.get(ILifecycleService);
294+
295+
lifecycleService.phase = LifecyclePhase.Running;
296+
297+
console.log(LifecyclePhase.Running);
298+
289299
const editorApi = {
290300
openFile(path: string) {
291301
return codeEditorService.openCodeEditor({

packages/app/src/app/store/modules/editor/actions.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,17 @@ export function getIdFromModulePath({ props, state, utils }) {
2525

2626
const sandbox = state.get('editor.currentSandbox');
2727

28-
const module = utils.resolveModule(
29-
props.path.replace(/^\//, ''),
30-
sandbox.modules,
31-
sandbox.directories
32-
);
28+
try {
29+
const module = utils.resolveModule(
30+
props.path.replace(/^\//, ''),
31+
sandbox.modules,
32+
sandbox.directories
33+
);
3334

34-
return { id: module.id };
35+
return { id: module.id };
36+
} catch (e) {
37+
return {};
38+
}
3539
}
3640

3741
export function addNpmDependencyToPackage({ state, props }) {

packages/app/src/app/store/modules/editor/sequences.js

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,21 +61,27 @@ export const changeCurrentModule = [
6161
track('Open File', {}),
6262
setReceivingStatus,
6363
actions.getIdFromModulePath,
64-
setCurrentModule(props`id`),
65-
equals(state`live.isLive`),
64+
when(props`id`),
6665
{
6766
true: [
68-
equals(state`live.isCurrentEditor`),
67+
setCurrentModule(props`id`),
68+
equals(state`live.isLive`),
6969
{
7070
true: [
71-
getSelectionsForCurrentModule,
72-
set(state`editor.pendingUserSelections`, props`selections`),
73-
sendChangeCurrentModule,
71+
equals(state`live.isCurrentEditor`),
72+
{
73+
true: [
74+
getSelectionsForCurrentModule,
75+
set(state`editor.pendingUserSelections`, props`selections`),
76+
sendChangeCurrentModule,
77+
],
78+
false: [],
79+
},
7480
],
7581
false: [],
7682
},
7783
],
78-
false: [],
84+
false: [clearCurrentModule],
7985
},
8086
];
8187

0 commit comments

Comments
 (0)