Fix updating package.json with live

Author: CompuIves

packages/app/src/app/overmind/namespaces/editor/actions.ts

@@ -285,7 +285,7 @@ export const onOperationApplied: Action<{
     return;
   }
 
-  actions.editor.internal.setModuleCode({
+  actions.editor.internal.setStateModuleCode({
     module,
     code,
   });
@@ -316,28 +316,37 @@ export const codeChanged: Action<{
     return;
   }
 
-  if (state.live.isLive) {
-    const operation = event
-      ? eventToTransform(event, module.code).operation
-      : getTextOperation(module.code, code);
+  // module.code !== code check is there to make sure that we don't end up sending
+  // duplicate updates to live. module.code === code only when VSCode detected a change
+  // from the filesystem (fs changed, vscode sees it, sends update). If this happens we
+  // never want to send that code update, since this actual code change goes through this
+  // specific code flow already.
+  if (state.live.isLive && module.code !== code) {
+    let operation;
+    if (event) {
+      operation = eventToTransform(event, code);
+    } else {
+      const transform = getTextOperation(module.code, code);
+
+      operation = transform.operation;
+    }
 
     effects.live.sendCodeUpdate(moduleShortid, operation);
   }
 
-  actions.editor.internal.setModuleCode({
+  actions.editor.internal.setStateModuleCode({
     module,
     code,
   });
+  if (module.savedCode !== null && module.code === module.savedCode) {
+    effects.vscode.revertModule(module);
+  }
 
   const { isServer } = getTemplate(state.editor.currentSandbox.template);
 
   if (!isServer && state.preferences.settings.livePreviewEnabled) {
     actions.editor.internal.updatePreviewCode();
   }
-
-  if (module.savedCode !== null && module.code === module.savedCode) {
-    effects.vscode.revertModule(module);
-  }
 };
 
 export const saveClicked: AsyncAction = withOwnedSandbox(

packages/app/src/app/overmind/namespaces/editor/internalActions.ts

@@ -300,7 +300,7 @@ export const addNpmDependencyToPackageJson: AsyncAction<{
   });
 };
 
-export const setModuleCode: Action<{
+export const setStateModuleCode: Action<{
   module: Module;
   code: string;
 }> = ({ state, effects }, { module, code }) => {