Sentry bugrun (codesandbox#527)

* Fix sentry bugs

* Fix nullpointers

* Fix wrong path

Author: CompuIves

packages/app/src/app/components/NewSandbox/index.js

@@ -49,7 +49,7 @@ function NewSandbox({ signals }) {
           height={50}
           text="React"
           href={newSandboxUrl()}
-          onClick={() => signals.editor.newSandboxModalClosed()}
+          onClick={() => signals.closeModal()}
         />
 
         <Logo
@@ -58,7 +58,7 @@ function NewSandbox({ signals }) {
           height={50}
           text="Vue"
           href={newVueSandboxUrl()}
-          onClick={() => signals.editor.newSandboxModalClosed()}
+          onClick={() => signals.closeModal()}
         />
 
         <Logo
@@ -67,47 +67,47 @@ function NewSandbox({ signals }) {
           height={50}
           text="Angular"
           href={newAngularSandboxUrl()}
-          onClick={() => signals.editor.newSandboxModalClosed()}
+          onClick={() => signals.closeModal()}
         />
         <Logo
           Icon={PreactIcon}
           width={50}
           height={50}
           text="Preact"
           href={newPreactSandboxUrl()}
-          onClick={() => signals.editor.newSandboxModalClosed()}
+          onClick={() => signals.closeModal()}
         />
         <Logo
           Icon={SvelteIcon}
           width={50}
           height={50}
           text="Svelte"
           href={newSvelteSandboxUrl()}
-          onClick={() => signals.editor.newSandboxModalClosed()}
+          onClick={() => signals.closeModal()}
         />
         <Logo
           Icon={ReactIcon}
           width={50}
           height={50}
           text="React TypeScript"
           href={newReactTypeScriptSandboxUrl()}
-          onClick={() => signals.editor.newSandboxModalClosed()}
+          onClick={() => signals.closeModal()}
         />
         <Logo
           Icon={GithubIcon}
           width={50}
           height={50}
           text="Import from Github"
           href={importFromGitHubUrl()}
-          onClick={() => signals.editor.newSandboxModalClosed()}
+          onClick={() => signals.closeModal()}
         />
         <Logo
           Icon={TerminalIcon}
           width={50}
           height={50}
           text="Upload from CLI"
           href={uploadFromCliUrl()}
-          onClick={() => signals.editor.newSandboxModalClosed()}
+          onClick={() => signals.closeModal()}
         />
       </RowContainer>
     </Container>

packages/app/src/app/pages/Sandbox/Editor/Content/Tabs/index.js

@@ -43,9 +43,9 @@ class EditorTabs extends React.Component {
   closeListener = e => {
     if ((e.ctrlKey || e.metaKey) && e.keyCode === 87) {
       e.preventDefault();
-      const currentPos = this.props.tabs.findIndex(
-        t => t.moduleId === this.props.currentModuleId
-      );
+      const currentPos = this.props.tabs
+        .filter(x => x)
+        .findIndex(t => t.moduleId === this.props.currentModuleId);
       this.closeTab(currentPos);
     }
   };

packages/app/src/app/store/factories.js

@@ -42,7 +42,9 @@ export function setCurrentModuleById(id) {
       moduleEntry => moduleEntry.id === resolve.value(id)
     );
 
-    state.set('editor.currentModuleShortid', module.shortid);
+    if (module) {
+      state.set('editor.currentModuleShortid', module.shortid);
+    }
   };
 }
 

packages/app/src/app/store/modules/editor/actions.js

@@ -134,21 +134,27 @@ export function renameModuleFromPreview({ state, props, utils }) {
 
 export function addErrorFromPreview({ state, props, utils }) {
   const sandbox = state.get('editor.currentSandbox');
-  const module = utils.resolveModule(
-    props.action.path.replace(/^\//, ''),
-    sandbox.modules,
-    sandbox.directories
-  );
-  const error = {
-    moduleId: module.id,
-    column: props.action.column,
-    line: props.action.line,
-    message: props.action.message,
-    title: props.action.title,
-  };
 
-  if (module) {
-    state.push('editor.errors', error);
+  try {
+    const module = utils.resolveModule(
+      props.action.path.replace(/^\//, ''),
+      sandbox.modules,
+      sandbox.directories
+    );
+
+    const error = {
+      moduleId: module.id,
+      column: props.action.column,
+      line: props.action.line,
+      message: props.action.message,
+      title: props.action.title,
+    };
+
+    if (module) {
+      state.push('editor.errors', error);
+    }
+  } catch (e) {
+    /* ignore, module not found */
   }
 }
 

packages/app/src/app/store/modules/git/model.js

@@ -3,7 +3,7 @@ import { types } from 'mobx-state-tree';
 const Git = types.model({
   branch: types.string,
   commitSha: types.string,
-  path: types.string,
+  path: types.maybe(types.string),
   repo: types.string,
   username: types.string,
 });

packages/app/src/app/store/modules/git/sequences.js

@@ -22,7 +22,7 @@ export const createRepo = [
       set(state`currentModal`, null),
       actions.redirectToGithubSandbox,
     ],
-    false: set(state`git.error`, props`error`),
+    error: set(state`git.error`, props`error`),
   },
 ];
 

packages/app/src/app/store/modules/profile/model.js

@@ -22,7 +22,7 @@ export default {
       showcasedSandboxShortid: types.maybe(types.string),
       sandboxCount: types.number,
       receivedLikeCount: types.number,
-      name: types.string,
+      name: types.maybe(types.string),
       id: types.string,
       givenLikeCount: types.number,
       forkedCount: types.number,

standalone-packages/codesandbox-browserfs/src/backend/CodeSandboxFS.ts

@@ -198,7 +198,7 @@ export default class CodeSandboxFS extends SynchronousFileSystem
     };
     this.manager.addModule(module);
 
-    const buffer = Buffer.from(module.code);
+    const buffer = Buffer.from(module.code || '');
     const stats = new Stats(FileType.FILE, buffer.length);
 
     return new CodeSandboxFile(this, p, flag, stats, buffer);
@@ -212,7 +212,7 @@ export default class CodeSandboxFS extends SynchronousFileSystem
     }
 
     const { code = '' } = moduleInfo.module;
-    const buffer = Buffer.from(code);
+    const buffer = Buffer.from(code || '');
     const stats = new Stats(FileType.FILE, buffer.length);
 
     return new CodeSandboxFile(this, p, flag, stats, buffer);