Skip to content

Commit a9374fe

Browse files
authored
Disable throwing errors on dynamic dep fetch 404 (codesandbox#579)
1 parent c57271d commit a9374fe

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/app/src/sandbox/eval/manager.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,6 @@ export default class Manager {
475475
this.manifest.dependencies.find(d => d.name === dependencyName) ||
476476
this.manifest.dependencyDependencies[dependencyName]
477477
) {
478-
this.downloadDependency(connectedPath, currentPath);
479478
throw new ModuleNotFoundError(connectedPath, true);
480479
} else {
481480
throw new DependencyNotFoundError(connectedPath);

packages/app/src/sandbox/eval/npm/fetch-npm-module.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,9 @@ function resolvePath(
191191
},
192192
(err, resolvedPath) => {
193193
if (err) {
194-
console.error(err);
194+
if (process.env.NODE_ENV === 'development') {
195+
console.error(err);
196+
}
195197
return reject(err);
196198
}
197199

0 commit comments

Comments
 (0)