Skip to content

Commit a7b39c8

Browse files
committed
Remove spammy sentry event for firefox
1 parent 33271d9 commit a7b39c8

File tree

3 files changed

+40
-43
lines changed

3 files changed

+40
-43
lines changed

packages/common/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"@babel/polyfill": "^7.4.4",
4545
"@codesandbox/notifications": "^1.0.6",
4646
"@codesandbox/template-icons": "^1.0.1",
47-
"@sentry/browser": "^5.6.2",
47+
"@sentry/browser": "^5.9.0",
4848
"@tippy.js/react": "^2.1.1",
4949
"babel-plugin-preval": "^3.0.1",
5050
"babel-plugin-transform-es2015-modules-commonjs": "^6.26.2",

packages/common/src/utils/analytics/sentry.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,12 @@ export async function initialize(dsn: string) {
6767
return undefined;
6868
}
6969

70-
if (event?.message === 'Unexpected frame by generating stack.' && event?.tags?.handled === 'yes') {
71-
return undefined;
72-
}
73-
7470
if (
7571
event.message &&
76-
event.message.startsWith('Unexpected frame by generating stack.')
72+
event.message.includes('Unexpected frame by generating stack.')
7773
) {
7874
// A firefox error with error-polyfill, not critical. Referenced here: https://sentry.io/organizations/codesandbox/issues/1293236389/?project=155188&query=is%3Aunresolved
75+
return undefined;
7976
}
8077

8178
return event;

yarn.lock

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -3126,14 +3126,14 @@
31263126
conventional-changelog "0.0.17"
31273127
github-url-from-git "^1.4.0"
31283128

3129-
"@sentry/browser@^5.6.2":
3130-
version "5.6.2"
3131-
resolved "https://registry.yarnpkg.com/@sentry/browser/-/browser-5.6.2.tgz#f39e95c3aff2d4b4fd5d0d4aa7192af73f20d24e"
3132-
integrity sha512-Nm/W/5ra6+OQCWQkdd86vHjcYUjHCVqCzQyPasd6HE7SNlWe5euGVfFfDuUFsiDrMAG5uKfGYw5u/AqoweiQkQ==
3133-
dependencies:
3134-
"@sentry/core" "5.6.2"
3135-
"@sentry/types" "5.6.1"
3136-
"@sentry/utils" "5.6.1"
3129+
"@sentry/browser@^5.9.0":
3130+
version "5.9.0"
3131+
resolved "https://registry.yarnpkg.com/@sentry/browser/-/browser-5.9.0.tgz#09f6f544fce51d52f2e086ef776509b15ef04761"
3132+
integrity sha512-KTpmAau98QyJZtoV7LVYEFd1cdKQGk5yHlRyP3pCkhDcRbgicBNR3umdRDpsI5Ozgix3zNlyQprz0iQPmrPNRQ==
3133+
dependencies:
3134+
"@sentry/core" "5.8.0"
3135+
"@sentry/types" "5.7.1"
3136+
"@sentry/utils" "5.8.0"
31373137
tslib "^1.9.3"
31383138

31393139
"@sentry/cli@^1.44.4", "@sentry/cli@^1.47.1":
@@ -3148,46 +3148,46 @@
31483148
progress "2.0.0"
31493149
proxy-from-env "^1.0.0"
31503150

3151-
"@sentry/core@5.6.2":
3152-
version "5.6.2"
3153-
resolved "https://registry.yarnpkg.com/@sentry/core/-/core-5.6.2.tgz#8c5477654a83ebe41a72e86a79215deb5025e418"
3154-
integrity sha512-grbjvNmyxP5WSPR6UobN2q+Nss7Hvz+BClBT8QTr7VTEG5q89TwNddn6Ej3bGkaUVbct/GpVlI3XflWYDsnU6Q==
3151+
"@sentry/core@5.8.0":
3152+
version "5.8.0"
3153+
resolved "https://registry.yarnpkg.com/@sentry/core/-/core-5.8.0.tgz#bbfd2f4711491951a8e3a0e8fa8b172fdf7bff6f"
3154+
integrity sha512-aAh2KLidIXJVGrxmHSVq2eVKbu7tZiYn5ylW6yzJXFetS5z4MA+JYaSBaG2inVYDEEqqMIkb17TyWxxziUDieg==
31553155
dependencies:
3156-
"@sentry/hub" "5.6.1"
3157-
"@sentry/minimal" "5.6.1"
3158-
"@sentry/types" "5.6.1"
3159-
"@sentry/utils" "5.6.1"
3156+
"@sentry/hub" "5.8.0"
3157+
"@sentry/minimal" "5.8.0"
3158+
"@sentry/types" "5.7.1"
3159+
"@sentry/utils" "5.8.0"
31603160
tslib "^1.9.3"
31613161

3162-
"@sentry/hub@5.6.1":
3163-
version "5.6.1"
3164-
resolved "https://registry.yarnpkg.com/@sentry/hub/-/hub-5.6.1.tgz#9f355c0abcc92327fbd10b9b939608aa4967bece"
3165-
integrity sha512-m+OhkIV5yTAL3R1+XfCwzUQka0UF/xG4py8sEfPXyYIcoOJ2ZTX+1kQJLy8QQJ4RzOBwZA+DzRKP0cgzPJ3+oQ==
3162+
"@sentry/hub@5.8.0":
3163+
version "5.8.0"
3164+
resolved "https://registry.yarnpkg.com/@sentry/hub/-/hub-5.8.0.tgz#56aaeb7324cb66d90db838011cb0127f5558007f"
3165+
integrity sha512-VdApn1ZCNwH1wwQwoO6pu53PM/qgHG+DQege0hbByluImpLBhAj9w50nXnF/8KzV4UoMIVbzCb6jXzMRmqqp9A==
31663166
dependencies:
3167-
"@sentry/types" "5.6.1"
3168-
"@sentry/utils" "5.6.1"
3167+
"@sentry/types" "5.7.1"
3168+
"@sentry/utils" "5.8.0"
31693169
tslib "^1.9.3"
31703170

3171-
"@sentry/minimal@5.6.1":
3172-
version "5.6.1"
3173-
resolved "https://registry.yarnpkg.com/@sentry/minimal/-/minimal-5.6.1.tgz#09d92b26de0b24555cd50c3c33ba4c3e566009a1"
3174-
integrity sha512-ercCKuBWHog6aS6SsJRuKhJwNdJ2oRQVWT2UAx1zqvsbHT9mSa8ZRjdPHYOtqY3DoXKk/pLUFW/fkmAnpdMqRw==
3171+
"@sentry/minimal@5.8.0":
3172+
version "5.8.0"
3173+
resolved "https://registry.yarnpkg.com/@sentry/minimal/-/minimal-5.8.0.tgz#b7ad5113504ab67f1ef2b0f465b7ba608e6b8dc5"
3174+
integrity sha512-MIlFOgd+JvAUrBBmq7vr9ovRH1HvckhnwzHdoUPpKRBN+rQgTyZy1o6+kA2fASCbrRqFCP+Zk7EHMACKg8DpIw==
31753175
dependencies:
3176-
"@sentry/hub" "5.6.1"
3177-
"@sentry/types" "5.6.1"
3176+
"@sentry/hub" "5.8.0"
3177+
"@sentry/types" "5.7.1"
31783178
tslib "^1.9.3"
31793179

3180-
"@sentry/types@5.6.1":
3181-
version "5.6.1"
3182-
resolved "https://registry.yarnpkg.com/@sentry/types/-/types-5.6.1.tgz#5915e1ee4b7a678da3ac260c356b1cb91139a299"
3183-
integrity sha512-Kub8TETefHpdhvtnDj3kKfhCj0u/xn3Zi2zIC7PB11NJHvvPXENx97tciz4roJGp7cLRCJsFqCg4tHXniqDSnQ==
3180+
"@sentry/types@5.7.1":
3181+
version "5.7.1"
3182+
resolved "https://registry.yarnpkg.com/@sentry/types/-/types-5.7.1.tgz#4c4c1d4d891b6b8c2c3c7b367d306a8b1350f090"
3183+
integrity sha512-tbUnTYlSliXvnou5D4C8Zr+7/wJrHLbpYX1YkLXuIJRU0NSi81bHMroAuHWILcQKWhVjaV/HZzr7Y/hhWtbXVQ==
31843184

3185-
"@sentry/utils@5.6.1":
3186-
version "5.6.1"
3187-
resolved "https://registry.yarnpkg.com/@sentry/utils/-/utils-5.6.1.tgz#69d9e151e50415bc91f2428e3bcca8beb9bc2815"
3188-
integrity sha512-rfgha+UsHW816GqlSRPlniKqAZylOmQWML2JsujoUP03nPu80zdN43DK9Poy/d9OxBxv0gd5K2n+bFdM2kqLQQ==
3185+
"@sentry/utils@5.8.0":
3186+
version "5.8.0"
3187+
resolved "https://registry.yarnpkg.com/@sentry/utils/-/utils-5.8.0.tgz#34683088159b9935f973b6e6cad1a1cc26bbddac"
3188+
integrity sha512-KDxUvBSYi0/dHMdunbxAxD3389pcQioLtcO6CI6zt/nJXeVFolix66cRraeQvqupdLhvOk/el649W4fCPayTHw==
31893189
dependencies:
3190-
"@sentry/types" "5.6.1"
3190+
"@sentry/types" "5.7.1"
31913191
tslib "^1.9.3"
31923192

31933193
"@sentry/webpack-plugin@^1.8.0":

0 commit comments

Comments
 (0)