Skip to content

Commit a4f0bc2

Browse files
committed
Revert "Make CircleCI bundle homepage/app in parallel"
This reverts commit 0a62b41.
1 parent e646ccc commit a4f0bc2

File tree

2 files changed

+7
-47
lines changed

2 files changed

+7
-47
lines changed

.circleci/config.yml

Lines changed: 7 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
paths:
4343
- ~/codesandbox-client
4444

45-
build-app:
45+
build-prod:
4646
docker:
4747
- image: circleci/node:9.11.1
4848
working_directory: ~/codesandbox-client
@@ -54,48 +54,18 @@ jobs:
5454
key: v8-prod-app-build-cache-master
5555
- run:
5656
name: Build Application
57-
command: yarn build:app
57+
command: yarn build:prod
5858
- save_cache:
5959
key: v8-prod-app-build-cache-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_SHA1 }}
6060
paths:
6161
- ./packages/app/www
62-
63-
build-homepage:
64-
docker:
65-
- image: circleci/node:9.11.1
66-
working_directory: ~/codesandbox-client
67-
steps:
68-
- restore_cache:
69-
key: v8-repo-{{ .Environment.CIRCLE_SHA1 }}
70-
- run:
71-
name: Build Application
72-
command: yarn build:homepage
73-
- save_cache:
74-
key: v8-prod-homepage-build-cache-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_SHA1 }}
75-
paths:
76-
- ./packages/homepage/public
77-
78-
build-combine:
79-
docker:
80-
- image: circleci/node:9.11.1
81-
working_directory: ~/codesandbox-client
82-
steps:
83-
- restore_cache:
84-
key: v8-repo-{{ .Environment.CIRCLE_SHA1 }}
85-
86-
# Restore app build
87-
- restore_cache:
88-
key: v8-prod-app-build-cache-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_SHA1 }}
89-
# Restore homepage build
90-
- restore_cache:
91-
key: v8-prod-homepage-build-cache-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_SHA1 }}
92-
- run:
93-
name: Build Application
94-
command: yarn build:combine
9562
- save_cache:
9663
key: v8-prod-build-cache-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_SHA1 }}
9764
paths:
9865
- ./www
66+
- store_artifacts:
67+
path: ./www
68+
destination: www
9969

10070
test-integrations:
10171
docker:
@@ -180,19 +150,12 @@ workflows:
180150
- lint:
181151
requires:
182152
- build-dependencies
183-
- build-app:
153+
- build-prod:
184154
requires:
185155
- build-dependencies
186-
- build-homepage:
187-
requires:
188-
- build-dependencies
189-
- build-combine:
190-
requires:
191-
- build-app
192-
- build-homepage
193156
- create-docker-image:
194157
requires:
158+
- build-prod
195159
- lint
196160
- test-integrations
197161
- test-jest
198-
- build-combine

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,9 @@
55
"private": true,
66
"scripts": {
77
"build": "yarn build:deps && yarn build:prod",
8-
"build:app": "lerna run build --scope app --stream",
9-
"build:homepage": "lerna run build --scope homepage --stream",
108
"build:prod": "lerna run build --scope app --scope homepage --parallel && gulp",
119
"build:clean": "lerna run build:clean --scope app --scope homepage && rimraf www",
1210
"build:deps": "lerna run build:dev --scope codesandbox-api --scope codesandbox-browserfs",
13-
"build:combine": "gulp",
1411
"start": "yarn build:deps && lerna run start --scope app --stream",
1512
"start:fast": "lerna run start --scope app --stream",
1613
"start:home": "lerna run start --scope homepage --stream",

0 commit comments

Comments
 (0)