Fix team live session join switching (codesandbox#2450)

* fix enum

* fix live handling refetchsandbox

* Finish team live switching

Author: CompuIves

packages/app/src/app/overmind/actions.ts

@@ -219,13 +219,15 @@ export const refetchSandboxInfo: AsyncAction = async ({
     sandbox.title = updatedSandbox.title;
     sandbox.team = updatedSandbox.team;
 
-    if (state.live.isLive) {
-      await actions.live.internal.disconnect();
+    state.live.isTeam = Boolean(sandbox.team);
 
-      if (sandbox.owned && sandbox.roomId) {
-        state.live.isTeam = Boolean(sandbox.team);
-      }
+    if (sandbox.roomId === updatedSandbox.roomId) {
+      return;
+    }
 
+    sandbox.roomId = updatedSandbox.roomId;
+    await actions.live.internal.disconnect();
+    if (updatedSandbox.owned && updatedSandbox.roomId) {
       await actions.live.internal.initialize(sandbox.roomId);
     }
   }

packages/app/src/app/overmind/effects/live/index.ts

@@ -82,6 +82,10 @@ export default {
     return _socket;
   },
   disconnect() {
+    if (!channel) {
+      return Promise.resolve({});
+    }
+
     return new Promise((resolve, reject) => {
       channel
         .leave()

packages/app/src/app/overmind/namespaces/editor/actions.ts

@@ -109,9 +109,7 @@ export const sandboxChanged: AsyncAction<{ id: string }> = withLoadApp<{
       state.live.isTeam = true;
     }
 
-    state.live.isLoading = true;
     await actions.live.internal.initialize(sandbox.roomId);
-    state.live.isLoading = false;
   } else if (sandbox.owned) {
     actions.files.internal.recoverFiles();
   }

packages/app/src/app/overmind/namespaces/live/actions.ts

@@ -30,8 +30,6 @@ export const createLiveClicked: AsyncAction<{
 
   const roomId = await effects.api.createLiveRoom(sandboxId);
   await actions.live.internal.initialize(roomId);
-
-  state.live.isLoading = false;
 };
 
 export const liveMessageReceived: Operator<LiveMessage> = pipe(

packages/app/src/app/overmind/namespaces/live/internalActions.ts

@@ -80,6 +80,8 @@ export const initialize: AsyncAction<string, Sandbox> = async (
     return sandbox;
   } catch (error) {
     state.live.error = error.reason;
+  } finally {
+    state.live.isLoading = false;
   }
 
   return null;