Don't show error response HTML in notification when uploaded file is … (codesandbox#3425)

* Don't show error response HTML in notification when uploaded file is too large.

* Refactor as per review.

Author: lbogdan

packages/app/src/app/overmind/internalActions.ts

@@ -390,7 +390,18 @@ export const handleError: Action<{
   */
   message: string;
   error: ApiError | Error;
-}> = ({ actions, effects }, { message, error }) => {
+  hideErrorMessage?: boolean;
+}> = ({ actions, effects }, { message, error, hideErrorMessage = false }) => {
+  if (hideErrorMessage) {
+    effects.analytics.logError(error);
+    effects.notificationToast.add({
+      message,
+      status: NotificationStatus.ERROR,
+    });
+
+    return;
+  }
+
   const isGenericError =
     !('response' in error) ||
     error.response == null ||

packages/app/src/app/overmind/namespaces/files/actions.ts

@@ -441,6 +441,7 @@ export const filesUploaded: AsyncAction<{
         actions.internal.handleError({
           message: `The uploaded file is bigger than 7MB, contact [email protected] if you want to raise this limit`,
           error,
+          hideErrorMessage: true,
         });
       } else {
         actions.internal.handleError({