Skip to content

Commit 943c2dd

Browse files
siddharthkpCompuIves
authored andcommitted
Make the status bar less distracting (codesandbox#2675)
* Make the status bar less distracting * Changed it to dark-3 to match new design(ish) * change in extension * updated theme snapshot * change (some) vscode-extensions usage to v10 * oh boy! Ives told me to edit this giant file * cache bust a little more
1 parent 036ed38 commit 943c2dd

File tree

10 files changed

+14
-16
lines changed

10 files changed

+14
-16
lines changed

packages/app/config/build.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ const isDev = process.env.NODE_ENV === 'development';
22
const staticAssets = [
33
{
44
from: 'standalone-packages/vscode-editor/release/min/vs',
5-
to: 'public/vscode23/vs',
5+
to: 'public/vscode24/vs',
66
},
77
{
88
from: 'standalone-packages/vscode-extensions/out',
9-
to: 'public/vscode-extensions/v9',
9+
to: 'public/vscode-extensions/v10',
1010
},
1111
{
1212
from: 'node_modules/onigasm/lib/onigasm.wasm',

packages/app/config/webpack.prod.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@ const webpack = require('webpack');
66
const ImageminPlugin = require('imagemin-webpack-plugin').default;
77
const SWPrecacheWebpackPlugin = require('sw-precache-webpack-plugin');
88
const TerserJSPlugin = require('terser-webpack-plugin');
9-
const BundleAnalyzerPlugin = require('webpack-bundle-analyzer')
10-
.BundleAnalyzerPlugin;
11-
const normalizeName = require('webpack/lib/optimize/SplitChunksPlugin')
12-
.normalizeName;
9+
const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
10+
const { normalizeName } = require('webpack/lib/optimize/SplitChunksPlugin');
1311
const ManifestPlugin = require('webpack-manifest-plugin');
1412
const CopyWebpackPlugin = require('copy-webpack-plugin');
1513
const VERSION = require('@codesandbox/common/lib/version').default;
@@ -182,7 +180,7 @@ module.exports = merge(commonConfig, {
182180
},
183181
},
184182
{
185-
urlPattern: /\/vscode23/,
183+
urlPattern: /\/vscode24/,
186184
handler: 'cacheFirst',
187185
options: {
188186
cache: {

packages/app/src/app/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@
6868
}
6969
</script>
7070

71-
<link data-name="/public/vscode23/vs/editor/editor.main" rel="preload" as="style" href="/public/vscode23/vs/editor/codesandbox.editor.main.css">
71+
<link data-name="/public/vscode24/vs/editor/editor.main" rel="preload" as="style" href="/public/vscode24/vs/editor/codesandbox.editor.main.css">
7272
</link>
73-
<link rel="preload" as="script" href="/public/vscode23/vs/editor/codesandbox.editor.main.js">
73+
<link rel="preload" as="script" href="/public/vscode24/vs/editor/codesandbox.editor.main.js">
7474
</link>
7575
</head>
7676

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
export const EXTENSIONS_LOCATION = process.env.VSCODE
22
? '/vscode/extensions-bundle'
3-
: '/public/vscode-extensions/v9';
3+
: '/public/vscode-extensions/v10';

packages/app/src/app/vscode/metadata.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const VSCODE_METADATA = {
22
CORE: {
33
paths: {
4-
src: process.env.VSCODE ? '/vscode/out/vs' : '/public/vscode23/vs',
4+
src: process.env.VSCODE ? '/vscode/out/vs' : '/public/vscode24/vs',
55
'npm/dev': 'node_modules/monaco-editor-core/dev/vs',
66
'npm/min': 'node_modules/monaco-editor-core/min/vs',
77
built: '/vscode/out-monaco-editor-core/min/vs',

packages/common/src/__snapshots__/theme.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Object {
6161
"scrollbarSlider.background": "#37414050",
6262
"sideBar.background": "#191d1f",
6363
"sideBar.border": "#111518",
64-
"statusBar.background": "#40A9F3",
64+
"statusBar.background": "#242424",
6565
"tab.activeBackground": "#1C2022",
6666
"tab.border": "#111518",
6767
"tab.inactiveBackground": "#111518",

packages/common/src/themes/codesandbox.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"scrollbarSlider.background": "#37414050",
2424
"sideBar.background": "#191d1f",
2525
"sideBar.border": "#111518",
26-
"statusBar.background": "#40A9F3",
26+
"statusBar.background": "#242424",
2727
"tab.activeBackground": "#1C2022",
2828
"tab.border": "#111518",
2929
"tab.inactiveBackground": "#111518",

standalone-packages/vscode-editor/release/min/vs/editor/codesandbox.editor.main.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

standalone-packages/vscode-extensions/out/extensions/index.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

standalone-packages/vscode-extensions/out/extensions/ngryman.codesandbox-theme-0.0.1/themes/CodeSandbox-color-theme.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"scrollbarSlider.background": "#37414050",
2323
"sideBar.background": "#191d1f",
2424
"sideBar.border": "#111518",
25-
"statusBar.background": "#40A9F3",
25+
"statusBar.background": "#242424",
2626
"tab.activeBackground": "#1C2022",
2727
"tab.border": "#111518",
2828
"tab.inactiveBackground": "#111518",

0 commit comments

Comments
 (0)