Skip to content

Commit 90e666a

Browse files
committed
Fix crashing editor if package.json is invalid
1 parent 8aa2a81 commit 90e666a

File tree

2 files changed

+4
-7
lines changed
  • packages

2 files changed

+4
-7
lines changed

packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/index.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ export const Dependencies: FunctionComponent = () => {
3636
return <ErrorMessage>Unable to find package.json</ErrorMessage>;
3737
}
3838

39-
const {
40-
parsed: { dependencies = {} /* devDependencies = {} */ },
41-
error,
42-
} = parsedConfigurations.package;
39+
const { parsed, error } = parsedConfigurations.package;
4340
if (error) {
4441
return (
4542
<ErrorMessage>We weren{"'"}t able to parse the package.json</ErrorMessage>
@@ -50,11 +47,11 @@ export const Dependencies: FunctionComponent = () => {
5047
return (
5148
<div>
5249
<Margin bottom={0}>
53-
{Object.keys(dependencies)
50+
{Object.keys(parsed.dependencies)
5451
.sort()
5552
.map(dependency => (
5653
<VersionEntry
57-
dependencies={dependencies}
54+
dependencies={parsed.dependencies}
5855
dependency={dependency}
5956
key={dependency}
6057
onRefresh={(name, version) => addNpmDependency({ name, version })}

packages/common/src/templates/template.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ export default class Template {
173173
*/
174174
getEntries(configurationFiles: ParsedConfigurationFiles): string[] {
175175
return [
176-
configurationFiles.package &&
176+
configurationFiles.package?.parsed &&
177177
this.getMainFromPackage(configurationFiles.package.parsed),
178178
...(this.mainFile || []),
179179
'/index.' + (this.isTypescript ? 'ts' : 'js'),

0 commit comments

Comments
 (0)