Fix resolving dynamic modules if no package.json exists

Author: CompuIves

packages/app/src/sandbox/eval/npm/fetch-npm-module.ts

@@ -106,9 +106,13 @@ function getUnpkgUrl(name: string, version: string, forceJsDelivr?: boolean) {
     : `https://unpkg.com/${nameWithoutAlias}@${version}`;
 }
 
-function getMeta(name: string, packageJSONPath: string, version: string) {
+function getMeta(
+  name: string,
+  packageJSONPath: string | null,
+  version: string
+) {
   const nameWithoutAlias = name.replace(ALIAS_REGEX, '');
-  const id = `${packageJSONPath}@${version}`;
+  const id = `${packageJSONPath || name}@${version}`;
   if (metas[id]) {
     return metas[id];
   }
@@ -262,12 +266,22 @@ function resolvePath(
   });
 }
 
+type DependencyVersionResult =
+  | {
+      version: string;
+      packageJSONPath: string;
+    }
+  | {
+      version: string;
+      packageJSONPath: null;
+    };
+
 async function findDependencyVersion(
   currentTModule: TranspiledModule,
   manager: Manager,
   defaultExtensions: Array<string> = ['js', 'jsx', 'json'],
   dependencyName: string
-) {
+): Promise<DependencyVersionResult | null> {
   const manifest = manager.manifest;
 
   try {
@@ -330,7 +344,7 @@ export default async function fetchModule(
     dependencyName
   );
 
-  if (!versionInfo) {
+  if (versionInfo === null) {
     throw new DependencyNotFoundError(path);
   }
 

packages/app/src/sandbox/index.js

@@ -110,6 +110,7 @@ requirePolyfills().then(() => {
           hasActions: false,
           template: x.data.template,
           version: 3,
+          disableDependencyPreprocessing: true,
         };
 
         compile(data);

…ox/version-resolving/merge-dependency.js …ox/version-resolving/merge-dependency.tspackages/app/src/sandbox/version-resolving/merge-dependency.js renamed to packages/app/src/sandbox/version-resolving/merge-dependency.ts packages/app/src/sandbox/version-resolving/merge-dependency.js renamed to packages/app/src/sandbox/version-resolving/merge-dependency.ts

@@ -3,27 +3,27 @@ import * as semver from 'semver';
 
 interface ILambdaResponse {
   contents: {
-    [path: string]: string,
+    [path: string]: string;
   };
   dependency: {
-    name: string,
-    version: string,
+    name: string;
+    version: string;
   };
   peerDependencies: {
-    [dep: string]: string,
+    [dep: string]: string;
   };
   dependencyDependencies: {
     [dep: string]: {
-      semver: string,
-      resolved: string,
-      parents: string[],
-      entries: string[],
-    },
+      semver: string;
+      resolved: string;
+      parents: string[];
+      entries: string[];
+    };
   };
   dependencyAliases: {
     [dep: string]: {
-      [dep: string]: string,
-    },
+      [dep: string]: string;
+    };
   };
 }
 
@@ -36,10 +36,10 @@ interface IDepDepInfo {
 
 interface IResponse {
   contents: { [path: string]: string };
-  dependencies: Array<{ name: string, version: string }>;
+  dependencies: Array<{ name: string; version: string }>;
   dependencyAliases: { [dep: string]: { [dep: string]: string } };
   dependencyDependencies: {
-    [dep: string]: IDepDepInfo,
+    [dep: string]: IDepDepInfo;
   };
 }
 
@@ -93,6 +93,7 @@ function replaceDependencyInfo(
   depDepName: string,
   newDepDep: IDepDepInfo
 ) {
+  // eslint-disable-next-line
   console.log(
     'Resolving conflict for ' +
       depDepName +
@@ -111,6 +112,7 @@ function replaceDependencyInfo(
   r.dependencyDependencies[newPath] = r.dependencyDependencies[depDepName];
   delete r.dependencyDependencies[depDepName];
 
+  // eslint-disable-next-line
   for (const n of Object.keys(r.dependencyDependencies)) {
     r.dependencyDependencies[n].parents = r.dependencyDependencies[
       n

…/version-resolving/resolve-dependency.js …/version-resolving/resolve-dependency.tspackages/app/src/sandbox/version-resolving/resolve-dependency.js renamed to packages/app/src/sandbox/version-resolving/resolve-dependency.ts packages/app/src/sandbox/version-resolving/resolve-dependency.js renamed to packages/app/src/sandbox/version-resolving/resolve-dependency.ts

@@ -26,10 +26,10 @@ function getLatestVersionForSemver(dep: string, version: string) {
 
 interface IPeerDependencyResult {
   [dep: string]: {
-    semver: string,
-    resolved: string,
-    parents: string[],
-    entries: string[],
+    semver: string;
+    resolved: string;
+    parents: string[];
+    entries: string[];
   };
 }
 
@@ -76,8 +76,8 @@ async function getDependencyDependencies(
 interface IResponse {
   contents: {};
   dependency: {
-    name: string,
-    version: string,
+    name: string;
+    version: string;
   };
   peerDependencies: { [name: string]: string };
   dependencyDependencies: IPeerDependencyResult;