Scripts spring cleanup (codesandbox#780)

* Updated package.json scripts for a better development experience and faster builds.

* Upgraded uglifyjs-webpack-plugin to 1.2.5.

* Removed unneeded babili-webpack-plugin.

* Added / updated details about the development environment.

* Added info on how to login on dev.

* CircleCI: use 'build:deps' to build dependencies.

* CircleCI: removed unneeded BrowserStack setup step.

* CircleCI: fixed build error when unavailable docker credentials.

* Renamed "dev[:smth]" scripts to "start[:smth]".

* CircleCI: Re-added BrowserStack, but only run it when credentials are set.

* CircleCI: moved Dockerfile from config to a file.

* Dummy commit

Author: lbogdan

.circleci/config.yml

@@ -36,7 +36,7 @@ jobs:
             - standalone-packages/codesandbox-browserfs/node_modules
       - run:
           name: Build
-          command: yarn build:dependents
+          command: yarn build:deps
       - save_cache:
           key: v8-repo-{{ .Environment.CIRCLE_SHA1 }}
           paths:
@@ -80,7 +80,7 @@ jobs:
           background: true
       - run:
           name: Setup BrowserStack local environment
-          command: ./packages/app/integration-tests/BrowserStackLocal --key $BROWSER_STACK_KEY
+          command: "[ -n \"$BROWSER_STACK_KEY\" ] && ./packages/app/integration-tests/BrowserStackLocal --key $BROWSER_STACK_KEY || true"
           background: true
       - run:
           name: Test Integrations
@@ -127,21 +127,13 @@ jobs:
           key: v8-prod-build-cache-{{ .Environment.CIRCLE_BRANCH }}-{{ .Environment.CIRCLE_SHA1 }}
       - run:
           name: Docker Sign In
-          command: "if [ -n $DOCKER_USER ]; then echo $DOCKER_PWD | docker login -u $DOCKER_USER --password-stdin; else exit 0; fi"
-      - run:
-          name: Create Dockerfile
-          command: |
-            cat > Dockerfile <<EOF
-            FROM busybox:1.28.1
-            WORKDIR /codesandbox
-            COPY www /codesandbox
-            EOF
+          command: "[ -n \"$DOCKER_USER\" ] && echo $DOCKER_PWD | docker login -u $DOCKER_USER --password-stdin || true"
       - run:
           name: Create Image
-          command: docker build -t codesandbox/client:${CIRCLE_SHA1:0:7} .
+          command: "[ -n \"$DOCKER_USER\" ] && docker build -t codesandbox/client:${CIRCLE_SHA1:0:7} . || true"
       - deploy:
           name: Push Image
-          command: "if [ -n $DOCKER_USER ]; then docker push codesandbox/client:${CIRCLE_SHA1:0:7}; else exit 0; fi"
+          command: "[ -n \"$DOCKER_USER\" ] && docker push codesandbox/client:${CIRCLE_SHA1:0:7} || true"
 
 workflows:
   version: 2

CONTRIBUTING.md

@@ -6,10 +6,11 @@ The CodeSandbox client is currently divided in to 5 parts. We use `lerna` to sha
 
 - `app`: The editor, the search, profile page, the embed and the sandbox.
 - `homepage`: The Gatsby website of the homepage.
-- `codesandbox-api`: The npm package that's responsible for communication between the sandbox and the editor.
 - `common`: All common parts between these packages, reusable JS.
+- `codesandbox-api`: The npm package that's responsible for communication between the sandbox and the editor.
+- `codesandbox-browserfs`: An in-browser file system that emulates the Node JS file system API and supports storing and retrieving files from various backends. Forked from [https://github.com/jvilk/BrowserFS](https://github.com/jvilk/BrowserFS), with an additional [CodeSandbox backend](https://github.com/CompuIves/codesandbox-client/blob/master/standalone-packages/codesandbox-browserfs/src/backend/CodeSandboxFS.ts).
 
-This version of CodeSandbox is using the production server as source of truth, this is specified by the environment variable `LOCAL_SERVER`. It's not yet possible to sign in using this version, I haven't figured out how to handle this yet.
+This version of CodeSandbox is using the production server as source of truth, this is specified by the environment variable `LOCAL_SERVER`. If you're working on a feature that needs you to be logged in, you can login on [https://codesandbox.io/](https://codesandbox.io/) and copy the contents of the `jwt` local storage key over to your development environment on [http://localhost:3000/](http://localhost:3000/). **Be very careful with how you handle the token**, as anyone who knows it can login as you and have read/write access to all your CodeSandbox content!
 
 **Working on your first Pull Request?** You can learn how from this *free* series [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github)
 
@@ -28,6 +29,9 @@ To install the project you need to have `yarn` and `node`
    ```
 2. `yarn` to install dependencies
 3. `yarn start` to start the app
+   * this builds the dependencies (`codesandbox-api` and `codesandbox-browserfs`) and runs the `app` development environment, available on [http://localhost:3000/s/new](http://localhost:3000/s/new)
+   * on subsequent runs you can also bypass dependencies building and use `yarn start:fast`
+   * if you want to work on the homepage, start it with `yarn start:home`, it will be available on [http://localhost:8000/](http://localhost:8000/)
 
 > Tip: Keep your `master` branch pointing at the original repository and make
 > pull requests from branches on your fork. To do this, run:

Dockerfile

@@ -0,0 +1,5 @@
+FROM busybox:1.28.1
+
+WORKDIR /codesandbox
+
+COPY www /codesandbox

package.json

@@ -4,11 +4,12 @@
   "license": "MIT",
   "private": true,
   "scripts": {
-    "build": "yarn build:dependents && yarn build:prod",
+    "build": "yarn build:deps && yarn build:prod",
     "build:prod": "lerna run build --scope app --scope homepage --parallel && gulp",
-    "build:dependents": "lerna run build --scope codesandbox-api --scope common --scope codesandbox-browserfs --stream && lerna run build --scope smooshpack --stream && lerna run build --scope react-smooshpack --stream",
-    "start": "lerna run build --scope codesandbox-browserfs --stream && lerna run start --parallel",
+    "build:deps": "lerna run build:dev --scope codesandbox-{api,browserfs}",
+    "start": "yarn build:deps && lerna run start --scope app --stream",
     "start:fast": "lerna run start --scope app --stream",
+    "start:home": "lerna run start --scope homepage --stream",
     "start:test": "lerna run start:test --scope app --stream",
     "start:dev_api": "lerna run start --parallel --ignore app & lerna run start:dev_api --scope app --stream",
     "test": "lerna run test --ignore codesandbox-browserfs",

packages/app/package.json

@@ -8,7 +8,7 @@
     "start:sandbox": "cross-env SANDBOX_ONLY=true node scripts/start.js",
     "start:dev_api": "node scripts/start.js",
     "start:test": "cross-env LOCAL_SERVER=1 NODE_ENV=test SANDBOX_ONLY=true node scripts/start.js",
-    "build": "NODE_ENV=production node scripts/build.js",
+    "build": "cross-env NODE_ENV=production node scripts/build.js",
     "build:sandbox": "cross-env NODE_ENV=production SANDBOX_ONLY=true node scripts/build.js",
     "test": "jest --env=jsdom",
     "test:watch": "jest --watch --env=jsdom",
@@ -36,7 +36,6 @@
     "babel-plugin-transform-runtime": "^6.23.0",
     "babel-preset-env": "^1.6.0",
     "babel-preset-react": "^6.24.1",
-    "babili-webpack-plugin": "^0.1.1",
     "buffer-loader": "^0.0.1",
     "case-sensitive-paths-webpack-plugin": "^2.0.0",
     "chalk": "1.1.3",
@@ -83,7 +82,7 @@
     "style-loader": "^0.18.2",
     "sw-precache-webpack-plugin": "^0.11.4",
     "typescript": "^2.4.2",
-    "uglifyjs-webpack-plugin": "^1.0.1",
+    "uglifyjs-webpack-plugin": "^1.2.5",
     "url-loader": "^0.5.9",
     "webpack": "^3.5.4",
     "webpack-bundle-analyzer": "^2.9.0",
@@ -106,8 +105,8 @@
     "babel-plugin-syntax-jsx": "^6.18.0",
     "babel-plugin-system-import": "^1.1.5",
     "babel-plugin-system-import-transformer": "3.1.0",
-    "babel-plugin-transform-cx-jsx": "^17.12.0",
     "babel-plugin-transform-async-to-generator": "^6.24.1",
+    "babel-plugin-transform-cx-jsx": "^17.12.0",
     "babel-plugin-transform-decorators-legacy": "^1.3.4",
     "babel-plugin-transform-remove-strict-mode": "^0.0.2",
     "babel-plugin-transform-vue-jsx": "^3.5.0",

packages/codesandbox-api/package.json

@@ -23,6 +23,7 @@
     "prebuild": "rimraf dist",
     "build:clean": "tsc && rollup -c",
     "build": "tsc && rollup -c && rimraf compiled && typedoc --out dist/docs --target es6 --theme minimal src",
+    "build:dev": "tsc && rollup -c",
     "start": "nodemon --watch \"src/**/*.ts\" -e ts --exec \"npm run build:clean\"",
     "test": "echo TODO",
     "test:watch": "jest --watch",

packages/codesandbox-api/rollup.config.js

@@ -26,4 +26,9 @@ export default {
     // Resolve source maps to the original source
     sourceMaps(),
   ],
+  onwarn: function(warning) {
+    if (warning.code !== 'THIS_IS_UNDEFINED') {
+      console.warn(warning);
+    }
+  },
 };

packages/homepage/package.json

@@ -37,8 +37,7 @@
   "license": "MIT",
   "main": "n/a",
   "scripts": {
-    "patch": "sed -i -e 's/if(c\\.initial) return;/if(!c||c.initial) return;/g' ../../node_modules/extract-text-webpack-plugin/index.js",
-    "build": "yarn patch && gatsby build && yarn remove-styles",
+    "build": "gatsby build && yarn remove-styles",
     "remove-styles": "rimraf public/styles.css",
     "start": "gatsby develop",
     "lint": "echo TODO && exit 0",

standalone-packages/codesandbox-browserfs/package.json

@@ -84,6 +84,7 @@
     "build:webpack-release": "webpack -p --config src/webpack.config.js",
     "watch:webpack-release": "webpack -w -p --config src/webpack.config.js",
     "build:all": "npm-run-all --parallel build:tsc build:scripts --sequential build:rollup --parallel build:webpack build:webpack-release",
+    "build:dev": "npm-run-all --parallel build:tsc build:scripts --sequential build:rollup --parallel build:webpack build:webpack-release --sequential script:make_dist",
     "start": "npm-run-all build --parallel watch:tsc watch:scripts watch:rollup watch:webpack watch:webpack-release",
     "test:build:tsc": "tsc -p test",
     "test:watch:tsc": "tsc --watch -p test",