fix typing

Author: christianalfoni

packages/app/src/app/overmind/effects/live/index.ts

@@ -209,7 +209,7 @@ class Live {
             reconnect_token: result.reconnectToken,
           });
 
-          this.presence = new Presence(this.channel);
+          this.presence = new Presence(this.channel!);
           this.presence.onSync(() => {
             this.connectionsCount = this.presence.list().length;
           });

packages/app/src/app/overmind/effects/vscode/ModelsHandler.ts

@@ -308,7 +308,7 @@ export class ModelsHandler {
    */
   public setModuleCode(module: Module, triggerChangeEvent = false) {
     const moduleModel = this.getModuleModelByPath(module.path);
-    const model = moduleModel.model;
+    const model = moduleModel?.model;
 
     if (!model) {
       return;

packages/app/src/app/overmind/namespaces/comments/actions.ts

@@ -369,7 +369,7 @@ export const addComment: AsyncAction<{
             lastUpdatedAt: sandbox.modules.find(
               module =>
                 module.path === optimisticComment.references[0].metadata.path
-            )?.updatedAt,
+            )!.updatedAt,
           }
         : null,
     });
@@ -526,6 +526,10 @@ export const onCommentAdded: Action<CommentAddedSubscription> = (
   if (comment.references[0] && comment.references[0].type === 'code') {
     const codeReference = comment.references[0].metadata;
     const sandbox = state.editor.currentSandbox;
+    if (!sandbox) {
+      return;
+    }
+
     const module = sandbox.modules.find(
       moduleItem => moduleItem.path === codeReference.path
     );

packages/app/src/app/overmind/namespaces/editor/actions.ts

@@ -441,7 +441,7 @@ export const saveClicked: AsyncAction = withOwnedSandbox(
         state.editor.changedModuleShortids.includes(module.shortid)
       );
 
-      if (COMMENTS) {
+      if (state.user?.experiments.comments) {
         const versions = await Promise.all(
           changedModules.map(module =>
             effects.live

packages/app/src/app/overmind/namespaces/editor/internalActions.ts

@@ -8,7 +8,6 @@ import {
   ServerContainerStatus,
   TabType,
 } from '@codesandbox/common/lib/types';
-import { COMMENTS } from '@codesandbox/common/lib/utils/feature-flags';
 import { hasPermission } from '@codesandbox/common/lib/utils/permission';
 import slugify from '@codesandbox/common/lib/utils/slugify';
 import {
@@ -127,7 +126,7 @@ export const saveCode: AsyncAction<{
   }
 
   try {
-    if (COMMENTS) {
+    if (state.user?.experiments.comments) {
       const {
         saved_code,
         updated_at,
@@ -273,6 +272,7 @@ export const removeNpmDependencyFromPackageJson: AsyncAction<string> = async (
   name
 ) => {
   if (
+    !state.editor.currentSandbox ||
     !state.editor.currentPackageJSONCode ||
     !state.editor.currentPackageJSON
   ) {
@@ -309,6 +309,7 @@ export const addNpmDependencyToPackageJson: AsyncAction<{
   isDev: boolean;
 }> = async ({ state, actions, effects }, { name, isDev, version }) => {
   if (
+    !state.editor.currentSandbox ||
     !state.editor.currentPackageJSONCode ||
     !state.editor.currentPackageJSON
   ) {
@@ -522,9 +523,7 @@ export const updateSandboxPackageJson: AsyncAction = async ({
   const code = JSON.stringify(parsed, null, 2);
   const moduleShortid = state.editor.currentPackageJSON.shortid;
 
-  const module = state.editor.currentSandbox.modules.find(
-    m => m.shortid === moduleShortid
-  );
+  const module = sandbox.modules.find(m => m.shortid === moduleShortid);
 
   if (!module) {
     return;

packages/app/src/app/overmind/namespaces/live/liveMessageOperators.ts

@@ -17,15 +17,27 @@ import { json, mutate } from 'overmind';
 
 export const onSave: Operator<LiveMessage<{
   saved_code: string;
+  updated_at: string;
+  inserted_at: string;
   version: number;
   path: string;
-}>> = mutate(({ effects, actions, state }, { data }) => {
+}>> = mutate(({ state }, { data }) => {
   const sandbox = state.editor.currentSandbox;
+
+  if (!sandbox) {
+    return;
+  }
   const module = sandbox.modules.find(
     moduleItem => moduleItem.path === data.path
   );
 
+  if (!module) {
+    return;
+  }
+
   module.savedCode = data.saved_code;
+  module.updatedAt = data.updated_at;
+  module.insertedAt = data.inserted_at;
   sandbox.version = data.version;
 });