Skip to content

Commit 7f7d16f

Browse files
authored
Sidebar - tiny design tweaks for themeing (codesandbox#3435)
* changed the toggle icon * current color for stats icon * link-color
1 parent 923b105 commit 7f7d16f

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

packages/components/src/components/Collapsible/index.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ export const Header = styled(SidebarRow).attrs({ gap: 2 })(
2121
cursor: 'pointer',
2222
':hover': {
2323
backgroundColor: 'sideBar.hoverBackground',
24-
svg: {
25-
// TODO: this should come from somewhere else - text muted maybe?
26-
color: 'grays.400',
27-
},
2824
},
2925
})
3026
);
@@ -37,7 +33,7 @@ const Icon = styled.svg<{
3733
transform: props.open ? 'rotate(0)' : 'rotate(-90deg)',
3834
transition: 'transform',
3935
transitionDuration: theme => theme.speeds[1],
40-
color: 'grays.500',
36+
opacity: 0.25,
4137
})
4238
);
4339

packages/components/src/components/Link/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const LinkElement = styled(Text).attrs({ as: 'a' })<ILinkProps>(
1717
transition: 'color ease',
1818
transitionDuration: theme => theme.speeds[2],
1919
':hover, :focus': {
20-
color: 'foreground',
20+
color: 'inherit',
2121
},
2222
})
2323
);

packages/components/src/components/Stats/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const HeartIcon = props => (
1313

1414
export const ViewIcon = props => (
1515
<svg width={16} height={16} fill="none" viewBox="0 0 16 16" {...props}>
16-
<g fill="#757575">
16+
<g fill="currentColor">
1717
<path
1818
fillRule="evenodd"
1919
d="M8 12.1c2.513 0 6.5-3.25 6.5-4.55S10.513 3 8 3 1.5 6.25 1.5 7.55c0 .975 3.987 4.55 6.5 4.55zm0-1.95a2.6 2.6 0 100-5.2 2.6 2.6 0 000 5.2z"

packages/components/src/examples/sandbox-info.stories.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
Stack,
1111
Switch,
1212
Text,
13+
Link,
1314
Label,
1415
SidebarRow,
1516
} from '../index';
@@ -20,8 +21,6 @@ export default {
2021
title: 'examples/SandboxInfo',
2122
};
2223

23-
const Link = props => <Text variant="muted" {...props} />;
24-
2524
const GlobeIcon = props => (
2625
<svg width={10} height={10} fill="none" viewBox="0 0 10 10" {...props}>
2726
<path
@@ -61,11 +60,15 @@ export const SandboxInfo = () => (
6160
</ListItem>
6261
<ListItem justify="space-between">
6362
<Text>Template</Text>
64-
<Link>React</Link>
63+
<Link href="#" variant="muted">
64+
React
65+
</Link>
6566
</ListItem>
6667
<ListItem justify="space-between">
6768
<Text>Environment</Text>
68-
<Link>create-react-app</Link>
69+
<Link href="#" variant="muted">
70+
create-react-app
71+
</Link>
6972
</ListItem>
7073
</List>
7174
</Stack>

0 commit comments

Comments
 (0)