Enable linting for common and sandbox

Author: CompuIves

.eslintrc

@@ -23,7 +23,7 @@
     "arrow-parens": 0,
     "import/prefer-default-export": 0,
     "class-methods-use-this": 0,
-    "no-console": ["error", { "allow": ["error"] }],
+    "no-console": ["error", { "allow": ["error", "warn"] }],
     "prefer-template": "off",
     "no-plusplus": 0,
     "no-underscore-dangle": "off",

packages/app/package.json

@@ -21,9 +21,10 @@
     "test": "jest --env=jsdom",
     "test:watch": "jest --watch --env=jsdom",
     "test:integrations": "jest --config integration-tests/jest.config.json --maxWorkers=2",
-    "lint": "npm run lint:app && npm run lint:embed",
+    "lint": "npm run lint:app && npm run lint:embed && npm run lint:sandbox",
     "lint:app": "cross-env LINT=1 eslint --ext .js,.ts,.tsx src/app",
     "lint:embed": "cross-env LINT=1 eslint --ext .js,.ts,.tsx src/embed",
+    "lint:sandbox": "cross-env LINT=1 eslint --ext .js,.ts,.tsx src/sandbox",
     "integrations:start": "docker run -v $(pwd):/app/ -it codesandbox/test yarn start:test",
     "typecheck": "tsc --noEmit -p tsconfig.check.json"
   },

packages/app/src/sandbox/compile-old.js

@@ -6,6 +6,7 @@ import parseConfigurations from '@codesandbox/common/lib/templates/configuration
 import initializeErrorTransformers from 'sandbox-hooks/errors/transformers';
 import { inject, unmount } from 'sandbox-hooks/react-error-overlay/overlay';
 import { isBabel7 } from '@codesandbox/common/lib/utils/is-babel-7';
+import { ParsedConfigurationFiles } from '@codesandbox/common/lib/templates/template';
 import getDefinition, {
   TemplateType,
 } from '@codesandbox/common/lib/templates/index';
@@ -31,7 +32,6 @@ import { consumeCache, saveCache, deleteAPICache } from './eval/cache';
 
 import { showRunOnClick } from './status-screen/run-on-click';
 import { Module } from './eval/entities/module';
-import { ParsedConfigurationFiles } from '@codesandbox/common/lib/templates/template';
 import TranspiledModule from './eval/transpiled-module';
 
 let initializedResizeListener = false;
@@ -64,8 +64,11 @@ export function getHTMLParts(html: string) {
   return { head: '', body: html };
 }
 
-function sendTestCount(manager: Manager, modules: { [path: string]: Module }) {
-  const testRunner = manager.testRunner;
+function sendTestCount(
+  givenManager: Manager,
+  modules: { [path: string]: Module }
+) {
+  const testRunner = givenManager.testRunner;
   const tests = testRunner.findTests(modules);
 
   dispatch({
@@ -623,6 +626,7 @@ async function compile({
             try {
               await evalBoilerplates(defaultBoilerplates);
             } catch (e) {
+              // eslint-disable-next-line no-console
               console.log("Couldn't load all boilerplates: " + e.message);
             }
           }
@@ -674,6 +678,7 @@ async function compile({
       }
     }, 600);
   } catch (e) {
+    // eslint-disable-next-line no-console
     console.log('Error in sandbox:');
     console.error(e);
 

packages/app/src/sandbox/compile.ts

@@ -51,7 +51,7 @@ export async function saveCache(
   firstRun: boolean
 ) {
   if (!sandboxId) {
-    return;
+    return Promise.resolve(false);
   }
 
   const managerState = {

packages/app/src/sandbox/eval/cache.ts

@@ -9,6 +9,7 @@ import DependencyNotFoundError from 'sandbox-hooks/errors/dependency-not-found-e
  */
 export default function getDependency(dependencyPath: string) {
   if (dependencyPath === 'codesandbox-api') {
+    // eslint-disable-next-line
     return require('codesandbox-api');
   }
 

packages/app/src/sandbox/eval/loaders/@babel-runtime.no-webpack.js

@@ -1,3 +1,4 @@
+/* eslint-disable */
 // from https://unpkg.com/[email protected]/browser.js
 
 const process = {};