Skip to content

Commit 7d16d42

Browse files
committed
Make type fetching a promise
1 parent edb9526 commit 7d16d42

File tree

3 files changed

+362
-243
lines changed

3 files changed

+362
-243
lines changed

standalone-packages/monaco-typescript/release/dev/tsWorker.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ define(["require", "exports", "./lib/typescriptServices", "./lib/lib", "./fetchD
127127
var devDependencies_1 = p_1.devDependencies || {};
128128
Promise.join(__spread(Object.keys(p_1.dependencies), Object.keys(devDependencies_1).filter(function (p) { return p.indexOf('@types/') === 0; })).map(function (depName) {
129129
var version = p_1.dependencies[depName] || devDependencies_1[depName];
130-
fetchTypings.fetchAndAddDependencies(depName, version, function (paths) {
130+
return fetchTypings.fetchAndAddDependencies(depName, version, function (paths) {
131131
var fileAmount = Object.keys(paths).length;
132132
Object.keys(paths).forEach(function (p) {
133133
var pathToWrite = '/sandbox/' + p;
@@ -140,10 +140,12 @@ define(["require", "exports", "./lib/typescriptServices", "./lib/lib", "./fetchD
140140
});
141141
}
142142
});
143-
}).catch(function (e) { });
143+
}).catch(function () { });
144144
})).then(function () {
145-
_this.typesLoaded = true;
146145
_this._languageService.cleanupSemanticCache();
146+
setTimeout(function () {
147+
_this.typesLoaded = true;
148+
});
147149
});
148150
}
149151
catch (e) {

standalone-packages/monaco-typescript/src/fetchDependencyTypings.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ const getFileTypes = (
334334
return Promise.all(
335335
dependencies
336336
.map(depPath =>
337-
fetchAndAddDependencies(getDependencyName(depPath), "latest", () => {}, fetchedPaths).catch(
337+
fetchAndAddDependencies(getDependencyName(depPath), "latest", fetchedPaths).catch(
338338
() => {
339339
/* ignore */
340340
}
@@ -421,7 +421,6 @@ function fetchFromTypings(dependency, version, fetchedPaths) {
421421
export async function fetchAndAddDependencies(
422422
dep,
423423
version,
424-
onDependencies,
425424
fetchedPaths = {}
426425
) {
427426
try {
@@ -453,5 +452,5 @@ export async function fetchAndAddDependencies(
453452
// }
454453
}
455454

456-
onDependencies(fetchedPaths);
455+
return fetchedPaths;
457456
}

0 commit comments

Comments
 (0)