clean FS on changing sandbox, improve create LIVE experience

Author: christianalfoni

packages/app/src/app/overmind/effects/vscode/SandboxFsSync/index.ts

@@ -72,6 +72,7 @@ class SandboxFsSync {
   public dispose() {
     this.isDisposed = true;
     self.removeEventListener('message', this.onWorkerMessage);
+    this.clearSandboxFiles();
   }
 
   public create(sandbox: Sandbox): SandboxFs {
@@ -401,6 +402,29 @@ class SandboxFsSync {
 
     return files;
   }
+
+  private clearSandboxFiles(dir = '/sandbox') {
+    if (dir === '/sandbox/node_modules') {
+      return;
+    }
+
+    const kids = browserFs.readdirSync(dir);
+
+    kids.forEach(kid => {
+      const path = join(dir, kid);
+      const lstat = browserFs.lstatSync(path);
+
+      if (lstat.isDirectory()) {
+        this.clearSandboxFiles(path);
+      } else {
+        browserFs.unlinkSync(path);
+      }
+    });
+
+    if (dir !== '/sandbox') {
+      browserFs.rmdirSync(dir);
+    }
+  }
 }
 
 export default SandboxFsSync;

packages/app/src/app/overmind/namespaces/editor/internalActions.ts

@@ -345,7 +345,11 @@ export const forkSandbox: AsyncAction<{
       forkedSandbox
     );
     effects.preview.updateAddressbarUrl();
-    actions.workspace.openDefaultItem();
+
+    if (state.workspace.openedWorkspaceItem === 'project-summary') {
+      actions.workspace.openDefaultItem();
+    }
+
     effects.notificationToast.success('Forked sandbox!');
     effects.router.updateSandboxUrl(forkedSandbox);
   } catch (error) {

packages/app/src/app/overmind/namespaces/live/actions.ts

@@ -42,18 +42,20 @@ export const createLiveClicked: AsyncAction<{
 }> = async ({ state, effects, actions }, { sandboxId }) => {
   effects.analytics.track('Create Live Session');
 
-  await effects.vscode.closeAllTabs();
-
   const roomId = await effects.api.createLiveRoom(sandboxId);
   const sandbox = await actions.live.internal.initialize(roomId);
-  actions.internal.setCurrentSandbox(sandbox);
 
-  await effects.vscode.changeSandbox(state.editor.currentSandbox, fs => {
-    state.editor.modulesByPath = fs;
+  Object.assign(sandbox, {
+    modules: sandbox.modules.map(module => ({
+      ...module,
+      code: state.editor.currentSandbox.modules.find(
+        currentSandboxModule => currentSandboxModule.shortid === module.shortid
+      ).code,
+    })),
   });
 
-  effects.vscode.openModule(state.editor.currentModule);
-  effects.preview.executeCodeImmediately({ initialRender: true });
+  Object.assign(state.editor.sandboxes[state.editor.currentId], sandbox);
+  state.editor.modulesByPath = effects.vscode.sandboxFsSync.create(sandbox);
 };
 
 export const liveMessageReceived: Operator<LiveMessage> = pipe(

standalone-packages/codesandbox-browserfs/src/backend/CodeSandboxEditorFS.ts

@@ -291,6 +291,10 @@ export default class CodeSandboxEditorFS extends SynchronousFileSystem
     // Stubbed
   }
 
+  public unlinkSync(p: string) {
+    // Stubbed
+  }
+
   public readdirSync(path: string): string[] {
     const paths = Object.keys(this.api.getSandboxFs());