Improvements to service workers and error handling

Author: CompuIves

packages/app/src/sandbox/compile.ts

@@ -708,14 +708,14 @@ async function compile({
 
     hadError = true;
   } finally {
-    try {
-      setTimeout(() => {
+    setTimeout(() => {
+      try {
         // Set a timeout so there's a chance that we also catch runtime errors
         localStorage.removeItem('running');
-      }, 600);
-    } catch (e) {
-      /* no */
-    }
+      } catch (e) {
+        /* no */
+      }
+    }, 600);
 
     if (manager) {
       const managerState = {

packages/app/src/sandbox/index.js

@@ -18,6 +18,17 @@ import { show404 } from 'sandbox-hooks/not-found-screen';
 
 import compile, { getCurrentManager } from './compile';
 
+Object.defineProperty(window, 'localStorage', {
+  get() {
+    return {};
+  },
+});
+Object.defineProperty(window, 'indexedDB', {
+  get() {
+    return {};
+  },
+});
+
 // Call this before importing React (or any other packages that might import React).
 initialize(window);
 

packages/common/src/registerServiceWorker.ts

@@ -76,7 +76,7 @@ function registerValidSW(
           } else if (installingWorker.state === 'redundant') {
             if ('storage' in navigator && 'estimate' in navigator.storage) {
               navigator.storage.estimate().then(results => {
-                const percentUsed = (results.usage / results.quota) * 100;
+                const percentUsed = results.usage / results.quota;
                 // Let's assume that if we're using 95% of our quota, then this failure
                 // was due to quota exceeded errors.
                 // TODO: Hardcoding a threshold stinks.