Skip to content

Commit 626828d

Browse files
committed
handle select of versions with css
1 parent c891eb6 commit 626828d

File tree

2 files changed

+20
-22
lines changed
  • packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/VersionEntry

2 files changed

+20
-22
lines changed

packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/VersionEntry/elements.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ export const Version = styled.div`
77
position: absolute;
88
right: ${props => (props.hovering ? (props.withSize ? 5 : 3.5) : 1)}rem;
99
color: ${props => props.theme.background.lighten(2).clearer(0.5)};
10+
display: ${props => (props.hovering ? 'none' : 'block')};
1011
`;
1112

1213
export const MoreData = styled(EntryContainer)`
@@ -28,9 +29,10 @@ export const MoreData = styled(EntryContainer)`
2829
`;
2930

3031
export const VersionSelect = styled(Select)`
32+
visibility: ${props => (props.hovering ? 'visible' : 'hidden')};
3133
width: 60px;
3234
position: absolute;
33-
right: ${props => (props.hovering ? (props.withSize ? 5 : 3.5) : 1)}rem;
35+
right: 5rem;
3436
color: ${props => props.theme.background.lighten(2)};
3537
margin-top: -4px;
3638
`;

packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/VersionEntry/index.js

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -136,27 +136,23 @@ export default class VersionEntry extends React.PureComponent {
136136
<Link href={`https://www.npmjs.com/package/${dependency}`}>
137137
{dependency}
138138
</Link>
139-
{hovering ? (
140-
<VersionSelect
141-
withSize={!!size.size}
142-
hovering={hovering}
143-
onChange={e => {
144-
this.props.onRefresh(dependency, e.target.value);
145-
this.setState({ hovering: false });
146-
}}
147-
>
148-
{versions.map(a => (
149-
<option key={a} selected={a === dependencies[dependency]}>
150-
{a}
151-
</option>
152-
))}
153-
</VersionSelect>
154-
) : (
155-
<Version withSize={!!size.size} hovering={hovering}>
156-
{dependencies[dependency]}{' '}
157-
{hovering && version && <span>({version})</span>}
158-
</Version>
159-
)}
139+
<VersionSelect
140+
hovering={hovering}
141+
onChange={e => {
142+
this.props.onRefresh(dependency, e.target.value);
143+
this.setState({ hovering: false });
144+
}}
145+
>
146+
{versions.map(a => (
147+
<option key={a} selected={a === dependencies[dependency]}>
148+
{a}
149+
</option>
150+
))}
151+
</VersionSelect>
152+
<Version withSize={!!size.size} hovering={hovering}>
153+
{dependencies[dependency]}{' '}
154+
{hovering && version && <span>({version})</span>}
155+
</Version>
160156

161157
{hovering && (
162158
<IconArea>

0 commit comments

Comments
 (0)