Skip to content

Commit 5d1a7b5

Browse files
mike-northCompuIves
authored andcommitted
Ember.js support (codesandbox#1113)
* feat: ember.js project template * cleanup * Update ember icon * ember - colors, logo, etc... for front page * Update index.js
1 parent 5f7e81a commit 5d1a7b5

File tree

8 files changed

+57
-1
lines changed

8 files changed

+57
-1
lines changed

packages/common/components/logos/Ember.js

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/common/templates/ember.js

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
// @flow
2+
import Template from './template';
3+
import { decorateSelector } from '../theme';
4+
5+
export default new Template(
6+
'ember',
7+
'Ember',
8+
'https://emberjs.com/',
9+
/**
10+
* Ideally, we'd point to https://github.com/ember-cli/ember-new-output
11+
* but there are a few tweaks that must be addressed before then.
12+
* - Auto-detection of ember-cli projects as node projects,
13+
* without requiring a sandbox.config.json
14+
* PR: https://github.com/codesandbox-app/codesandbox-importers/pull/16
15+
* - Ember-CLI initial build chokes on empty app/styles/app.css file
16+
* - A small livereload fix, for proper port detection through the CSB proxy stuff
17+
* BUG: https://github.com/ember-cli/ember-cli/issues/8073
18+
*
19+
* Here is a complete diff of these changes, w.r.t. the code generated by
20+
* `ember new my-app`
21+
*
22+
* https://github.com/ember-cli/ember-new-output/compare/master...mike-north:master
23+
*/
24+
'github/mike-north/ember-new-output',
25+
decorateSelector(() => '#E04E39'),
26+
{
27+
isServer: true,
28+
showOnHomePage: true,
29+
main: false
30+
}
31+
);

packages/common/templates/icons.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import React from 'common/components/logos/React';
44
import Angular from 'common/components/logos/Angular';
5+
import Ember from 'common/components/logos/Ember';
56
import Parcel from 'common/components/logos/Parcel';
67
import Preact from 'common/components/logos/Preact';
78
import Vue from 'common/components/logos/Vue';
@@ -17,6 +18,7 @@ import Apollo from 'common/components/logos/Apollo';
1718

1819
import {
1920
react,
21+
ember,
2022
vue,
2123
preact,
2224
reactTs,
@@ -53,6 +55,8 @@ export default function getIcon(theme: Template) {
5355
return Parcel;
5456
case dojo.name:
5557
return Dojo;
58+
case ember.name:
59+
return Ember;
5660
case cxjs.name:
5761
return CxJS;
5862
case reason.name:

packages/common/templates/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import react from './react';
88
import reactTs from './react-ts';
99
import svelte from './svelte';
1010
import vue from './vue';
11+
import ember from './ember';
1112
import cxjs from './cxjs';
1213
import dojo from './dojo';
1314
import gatsby from './gatsby';
@@ -35,6 +36,7 @@ export {
3536
svelte,
3637
vue,
3738
sapper,
39+
ember,
3840
};
3941

4042
export type Template =

packages/homepage/content/docs/2-importing.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ We infer sandbox settings based on several files in a repository.
3232
| Template - React | If `package.json` dependencies contains `react-scripts`. |
3333
| Template - React-Typescript | If `package.json` dependencies contains `react-scripts-ts`. |
3434
| Template - Svelte | If `package.json` dependencies contains `svelte`. |
35+
| Template - Node | If `package.json` dependencies contains `ember-cli`. |
3536

3637
Additionally, you may specify a `template` property in your `./sandbox.config.json` file.
3738

packages/homepage/src/screens/home/Animation/Background.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export default class Background extends React.PureComponent {
3131
'@dojo/cli-create-app': '#211D1C',
3232
'vue-cli': '#1D2525',
3333
'preact-cli': '#202328',
34+
'ember': '#2a201d',
3435
svelte: '#202022',
3536
};
3637

packages/homepage/src/screens/home/Animation/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
parcel,
1717
cxjs,
1818
dojo,
19+
ember,
1920
} from 'common/templates';
2021

2122
import Background from './Background';
@@ -66,7 +67,7 @@ const Message = styled.div`
6667
`};
6768
`;
6869

69-
const TEMPLATES = [parcel, react, vue, angular, preact, svelte, cxjs, dojo];
70+
const TEMPLATES = [parcel, react, vue, angular, preact, svelte, cxjs, dojo, ember];
7071

7172
export default class Animation extends React.PureComponent {
7273
state = {

packages/homepage/src/screens/home/Frameworks/index.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,11 @@ const TEMPLATE_SUPPORT = {
256256
css: ['Global', 'Modules'],
257257
description: 'Used for any kind of project, based on: ',
258258
},
259+
ember: {
260+
loaders: [js, ts, image, scss, sass, less],
261+
css: ['Global', 'Modules'],
262+
description: 'Used for any kind of project, based on: ',
263+
},
259264
};
260265

261266
export default class Frameworks extends React.Component {

0 commit comments

Comments
 (0)