Fix many code updating bugs

Author: Ives van Hoorne

packages/app/src/app/components/CodeEditor/Monaco/index.js

@@ -397,6 +397,9 @@ class MonacoEditor extends React.Component<Props, State> implements Editor {
       nextId: newModule.id,
       nextTitle: newModule.title,
     }).then(() => {
+      // Mark as receiving code so we don't send operations to others because
+      // of a module switch
+      this.receivingCode = true;
       if (newModule === this.currentModule) {
         this.changeCode(newModule.code || '');
       }
@@ -414,6 +417,7 @@ class MonacoEditor extends React.Component<Props, State> implements Editor {
         // that the changes of code are not sent to live users. We need to reset
         // this state when we're doing changing modules
         this.props.onCodeReceived();
+        this.receivingCode = false;
       }
     });
   };
@@ -798,6 +802,12 @@ class MonacoEditor extends React.Component<Props, State> implements Editor {
           module.id
         );
 
+        if (path === '') {
+          // Parent dir got deleted
+          this.disposeModel(module.id);
+          return;
+        }
+
         // Check for changed path, if that's
         // the case create a new model with corresponding tag, ditch the other model
         if (path !== modelCache[module.id].model.uri.path) {

packages/app/src/app/pages/Sandbox/Editor/Content/index.js

@@ -269,6 +269,7 @@ class EditorPreview extends React.Component<Props, State> {
           const corrections = store.editor.corrections.map(e => e);
           changeModule(newModule, errors, corrections);
         } else if (editor.changeCode) {
+          // Only code changed from outside the editor
           editor.changeCode(newModule.code || '');
         }
       }

packages/app/src/app/store/modules/live/sequences.js

@@ -127,10 +127,12 @@ export const handleMessage = [
         true: [],
         false: [
           actions.consumeModule,
+          actions.setReceivingStatus,
           set(props`shortid`, props`moduleShortid`),
           set(props`code`, props`module.code`),
           changeCode,
           setModuleSaved,
+          actions.unSetReceivingStatus,
         ],
       },
     ],

packages/common/sandbox/modules.js

@@ -153,6 +153,13 @@ export const getModulePath = (
 
   let directory = findByShortid(directories, module.directoryShortid);
   let path = '/';
+
+  if (directory == null && module.directoryShortid) {
+    // Parent got deleted, return '';
+
+    return '';
+  }
+
   while (directory != null) {
     path = `/${directory.title}${path}`;
     const lastDirectoryShortid = directory.directoryShortid;