Cleanup code (codesandbox#1874)

MichaelDeBoey · CompuIves · commit 5181fc2a794b · 2019-05-10T12:15:41.000+02:00
* Use includes

* Use Boolean function instead of double negation
diff --git a/packages/app/src/app/components/CodeEditor/VSCode/index.tsx b/packages/app/src/app/components/CodeEditor/VSCode/index.tsx
@@ -129,7 +129,7 @@ class MonacoEditor extends React.Component<Props> implements Editor {
     const activeEditor = this.editor && this.editor.getActiveCodeEditor();
 
     if (this.props.readOnly !== nextProps.readOnly && activeEditor) {
-      activeEditor.updateOptions({ readOnly: !!nextProps.readOnly });
+      activeEditor.updateOptions({ readOnly: Boolean(nextProps.readOnly) });
     }
 
     return false;
@@ -1012,7 +1012,7 @@ class MonacoEditor extends React.Component<Props> implements Editor {
 
     const mode = await getMode(title, this.monaco);
     if (this.settings.lintEnabled) {
-      if (mode === 'javascript' || mode === 'typescript' || mode === 'vue') {
+      if (['javascript', 'typescript', 'vue'].includes(mode)) {
         if (this.lintWorker) {
           this.lintWorker.postMessage({
             code,
@@ -1091,7 +1091,7 @@ class MonacoEditor extends React.Component<Props> implements Editor {
     return {
       ...getSettings(settings),
       ariaLabel: currentModule.title,
-      readOnly: !!this.props.readOnly,
+      readOnly: Boolean(this.props.readOnly),
     };
   };
 
diff --git a/packages/app/src/app/components/Preview/DevTools/index.tsx b/packages/app/src/app/components/Preview/DevTools/index.tsx
@@ -111,7 +111,7 @@ export default class DevTools extends React.PureComponent<Props, State> {
   constructor(props: Props) {
     super(props);
 
-    const isOpen = !!props.viewConfig.open;
+    const isOpen = Boolean(props.viewConfig.open);
 
     this.allViews = props.addedViews
       ? { ...VIEWS, ...props.addedViews }
diff --git a/packages/app/src/app/overmind/effects/fsSync.ts b/packages/app/src/app/overmind/effects/fsSync.ts
@@ -142,7 +142,7 @@ export default {
 
               fs.stat('/sandbox/tsconfig.json', (err, result) => {
                 // If tsconfig exists we want to sync the types
-                syncDependencyTypings(rv.toString(), !!err || !result);
+                syncDependencyTypings(rv.toString(), Boolean(err) || !result);
               });
             });
           }
diff --git a/packages/app/src/app/overmind/effects/keybindingManager.ts b/packages/app/src/app/overmind/effects/keybindingManager.ts
@@ -5,7 +5,7 @@ import {
 
 const isIOS =
   typeof navigator !== 'undefined' &&
-  !!navigator.platform.match(/(iPhone|iPod|iPad)/i);
+  Boolean(navigator.platform.match(/(iPhone|iPod|iPad)/i));
 
 const state = {
   keybindings: null,
diff --git a/packages/app/src/app/pages/Dashboard/Content/SandboxCard/index.tsx b/packages/app/src/app/pages/Dashboard/Content/SandboxCard/index.tsx
@@ -442,7 +442,7 @@ class SandboxItem extends React.PureComponent<Props, State> {
                   // check for cmd click
                   const cmd = event.ctrlKey || event.metaKey;
 
-                  this.openSandbox(!!cmd);
+                  this.openSandbox(Boolean(cmd));
                 }}
                 onBlur={this.handleOnBlur}
                 onFocus={this.handleOnFocus}
diff --git a/packages/app/src/app/pages/Dashboard/Content/routes/SearchSandboxes/index.js b/packages/app/src/app/pages/Dashboard/Content/routes/SearchSandboxes/index.js
@@ -65,7 +65,7 @@ const SearchSandboxes = ({ store }) => (
               isLoading={loading}
               Header={Header}
               page="search"
-              hideOrder={!!search}
+              hideOrder={Boolean(search)}
               sandboxes={loading ? [] : sandboxes}
               possibleTemplates={possibleTemplates}
             />
diff --git a/packages/app/src/app/pages/Sandbox/Editor/Workspace/WorkspaceItem/index.tsx b/packages/app/src/app/pages/Sandbox/Editor/Workspace/WorkspaceItem/index.tsx
@@ -27,7 +27,7 @@ export default class WorkspaceItem extends React.Component<Props, State> {
   constructor(props: Props) {
     super(props);
     this.state = {
-      open: !!props.defaultOpen,
+      open: Boolean(props.defaultOpen),
     };
   }
 
diff --git a/packages/app/src/app/pages/Sandbox/Editor/Workspace/items/ConfigurationFiles/index.js b/packages/app/src/app/pages/Sandbox/Editor/Workspace/items/ConfigurationFiles/index.js
@@ -38,7 +38,7 @@ const FileConfig = ({
   const { module, config } = info;
   return (
     <File
-      created={!!module}
+      created={Boolean(module)}
       key={path}
       onClick={
         openModule
diff --git a/packages/app/src/app/store/providers/FSSync.ts b/packages/app/src/app/store/providers/FSSync.ts
@@ -141,7 +141,7 @@ export default Provider({
 
               fs.stat('/sandbox/tsconfig.json', (err, result) => {
                 // If tsconfig exists we want to sync the types
-                syncDependencyTypings(rv.toString(), !!err || !result);
+                syncDependencyTypings(rv.toString(), Boolean(err) || !result);
               });
             });
           }
diff --git a/packages/app/src/app/vscode/dev-bootstrap.ts b/packages/app/src/app/vscode/dev-bootstrap.ts
@@ -478,7 +478,7 @@ export default function(isVSCode = false, requiredModule?: string[]) {
         return '';
       })
       .filter(function(assignment) {
-        return !!assignment;
+        return Boolean(assignment);
       })
       .join('&');
     if (search.length > 0) {
diff --git a/packages/app/src/sandbox/compile.ts b/packages/app/src/sandbox/compile.ts
@@ -510,7 +510,7 @@ async function compile({
 
     const foundMain = isModuleView
       ? entry
-      : possibleEntries.find(p => !!modules[p]);
+      : possibleEntries.find(p => Boolean(modules[p]));
 
     if (!foundMain) {
       throw new Error(
@@ -564,7 +564,7 @@ async function compile({
       if (!manager.webpackHMR) {
         const htmlModulePath = templateDefinition
           .getHTMLEntries(configurations)
-          .find(p => !!modules[p]);
+          .find(p => Boolean(modules[p]));
         const htmlModule = modules[htmlModulePath];
 
         const { head, body } = getHTMLParts(
diff --git a/packages/app/src/sandbox/eval/manager.ts b/packages/app/src/sandbox/eval/manager.ts
@@ -230,11 +230,11 @@ export default class Manager {
 
     if (returnValue == null && hasCallback && this.fileResolver) {
       return this.fileResolver.isFile(p).then(bool => {
-        callback(null, !!bool);
+        callback(null, Boolean(bool));
       });
     }
 
-    return hasCallback ? callback(null, !!returnValue) : !!returnValue;
+    return hasCallback ? callback(null, Boolean(returnValue)) : Boolean(returnValue);
   };
 
   readFileSync = (p: string, cb: Function | undefined, c?: Function) => {
diff --git a/packages/app/src/sandbox/eval/npm/fetch-npm-module.ts b/packages/app/src/sandbox/eval/npm/fetch-npm-module.ts
@@ -168,7 +168,7 @@ function resolvePath(
   const isFile = (p, c, cb) => {
     const callback = cb || c;
 
-    callback(null, !!manager.transpiledModules[p] || !!meta[p]);
+    callback(null, Boolean(manager.transpiledModules[p]) || Boolean(meta[p]));
   };
 
   return new Promise((res, reject) => {
diff --git a/packages/app/src/sandbox/eval/tests/jest-lite.ts b/packages/app/src/sandbox/eval/tests/jest-lite.ts
@@ -326,7 +326,7 @@ export default class TestRunner {
       name: error.name,
       message: error.message,
       stack: error.stack,
-      matcherResult: !!error.matcherResult,
+      matcherResult: Boolean(error.matcherResult),
       mappedErrors,
     };
   }
diff --git a/packages/app/src/sandbox/eval/transpilers/worker-transpiler.ts b/packages/app/src/sandbox/eval/transpilers/worker-transpiler.ts
@@ -257,7 +257,7 @@ export default abstract class WorkerTranspiler extends Transpiler {
       worker: true,
       hasFS: this.hasFS,
       workerCount: this.workerCount,
-      initialized: !!this.initialized,
+      initialized: Boolean(this.initialized),
     }));
   }
 }
diff --git a/packages/common/src/components/GithubBadge/index.tsx b/packages/common/src/components/GithubBadge/index.tsx
@@ -12,7 +12,7 @@ const DivOrA = ({ href, ...props }) =>
 function GithubBadge({ username, repo, url, branch, ...props }) {
   return (
     <DivOrA {...props} href={url}>
-      <BorderRadius hasUrl={!!url}>
+      <BorderRadius hasUrl={Boolean(url)}>
         <Icon>
           <GithubIcon />
         </Icon>
diff --git a/packages/common/src/components/Preview/index.tsx b/packages/common/src/components/Preview/index.tsx
@@ -240,7 +240,7 @@ class BasePreview extends React.Component<Props, State> {
   }
 
   setupSSESockets = async () => {
-    const hasInitialized = !!this.$socket;
+    const hasInitialized = Boolean(this.$socket);
 
     function onTimeout(comp: BasePreview) {
       comp.connectTimeout = null;
@@ -660,7 +660,7 @@ class BasePreview extends React.Component<Props, State> {
           externalResources: sandbox.externalResources,
           isModuleView: !this.props.isInProjectView,
           template: sandbox.template,
-          hasActions: !!this.props.onAction,
+          hasActions: Boolean(this.props.onAction),
         });
       }
     }
diff --git a/packages/common/src/components/Tags/Tag.tsx b/packages/common/src/components/Tags/Tag.tsx
@@ -9,7 +9,7 @@ export type Props = {
 
 export default function Tag({ tag, removeTag }: Props) {
   return (
-    <Container canRemove={!!removeTag}>
+    <Container canRemove={Boolean(removeTag)}>
       {tag}
       {removeTag && (
         <DeleteIcon
diff --git a/packages/common/src/components/UserWithAvatar/index.tsx b/packages/common/src/components/UserWithAvatar/index.tsx
@@ -29,7 +29,7 @@ export function UserWithAvatar({
         <Names>
           {name && <div>{name}</div>}
           {username && (
-            <Username hasTwoNames={name && !!username}>{username}</Username>
+            <Username hasTwoNames={name && Boolean(username)}>{username}</Username>
           )}
         </Names>
         {subscriptionSince && (
diff --git a/packages/common/src/config/env.ts b/packages/common/src/config/env.ts
@@ -4,7 +4,7 @@ import getHost from '../utils/host';
 
 const REACT_APP = /^REACT_APP_/i;
 const NODE_ENV = JSON.stringify(process.env.NODE_ENV || 'development');
-const LOCAL_SERVER = !!JSON.stringify(process.env.LOCAL_SERVER);
+const LOCAL_SERVER = Boolean(JSON.stringify(process.env.LOCAL_SERVER));
 
 export default Object.keys(process.env)
   .filter(key => REACT_APP.test(key))
@@ -16,8 +16,8 @@ export default Object.keys(process.env)
     {
       'process.env.NODE_ENV': NODE_ENV,
       'process.env.CODESANDBOX_HOST': JSON.stringify(getHost()),
-      'process.env.LOCAL_SERVER': !!LOCAL_SERVER,
+      'process.env.LOCAL_SERVER': Boolean(LOCAL_SERVER),
       'process.env.STAGING': 'STAGING_BRANCH' in process.env,
-      'process.env.VSCODE': !!JSON.stringify(process.env.VSCODE),
+      'process.env.VSCODE': Boolean(JSON.stringify(process.env.VSCODE)),
     }
   );
diff --git a/packages/common/src/utils/analytics.ts b/packages/common/src/utils/analytics.ts
@@ -9,10 +9,10 @@ const global = (typeof window !== 'undefined' ? window : {}) as any;
 
 export const DNT =
   typeof window !== 'undefined' &&
-  !!(
+  Boolean(
     global.doNotTrack === '1' ||
-    global.navigator.doNotTrack === '1' ||
-    global.navigator.msDoNotTrack === '1'
+      global.navigator.doNotTrack === '1' ||
+      global.navigator.msDoNotTrack === '1'
   );
 
 let sentryInitialized = false;
diff --git a/packages/common/src/utils/host.ts b/packages/common/src/utils/host.ts
@@ -1,4 +1,4 @@
-const IS_LOCAL_SERVER = !!JSON.stringify(process.env.LOCAL_SERVER);
+const IS_LOCAL_SERVER = Boolean(JSON.stringify(process.env.LOCAL_SERVER));
 
 export default () => {
   if (IS_LOCAL_SERVER) {
diff --git a/packages/common/src/utils/platform.ts b/packages/common/src/utils/platform.ts
@@ -1,9 +1,9 @@
 export const isIOS =
   typeof navigator !== 'undefined' &&
-  !!navigator.platform.match(/(iPhone|iPod|iPad)/i);
+  Boolean(navigator.platform.match(/(iPhone|iPod|iPad)/i));
 export const isSafari =
   typeof navigator !== 'undefined' &&
   /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
 export const isMac =
   typeof navigator !== 'undefined' &&
-  (isIOS || !!navigator.platform.match(/Mac/i));
+  (isIOS || Boolean(navigator.platform.match(/Mac/i)));
diff --git a/packages/react-sandpack/rollup.config.ts b/packages/react-sandpack/rollup.config.ts
@@ -9,7 +9,7 @@ const pkg = require('./package.json');
 
 const libraryName = 'react-sandpack';
 
-const minify = !!process.env.BUILD_MINIFY;
+const minify = Boolean(process.env.BUILD_MINIFY);
 
 function getFileName(name) {
   if (minify) {
diff --git a/packages/sandpack/src/manager/index.ts b/packages/sandpack/src/manager/index.ts
@@ -204,7 +204,7 @@ export default class PreviewManager {
       version: 3,
       modules,
       externalResources: [],
-      hasFileResolver: !!this.options.fileResolver,
+      hasFileResolver: Boolean(this.options.fileResolver),
       disableDependencyPreprocessing: this.sandboxInfo
         .disableDependencyPreprocessing,
       template:
diff --git a/standalone-packages/codesandbox-browserfs/src/backend/Dropbox.ts b/standalone-packages/codesandbox-browserfs/src/backend/Dropbox.ts
@@ -535,7 +535,7 @@ function ProcessListFolderError(e: DropboxTypes.Error<DropboxTypes.files.ListFol
 }
 
 function ContinueReadingDir(client: DropboxClient, path: string, res: DropboxTypes.files.ListFolderResult, previousEntries: string[], cb: BFSCallback<string[]>): void {
-  const newEntries = <string[]> res.entries.map((e) => e.path_display).filter((p) => !!p);
+  const newEntries = <string[]> res.entries.map((e) => e.path_display).filter(Boolean);
   const entries = previousEntries.concat(newEntries);
   if (!res.has_more) {
     cb(null, entries);
diff --git a/standalone-packages/codesandbox-browserfs/src/backend/HTML5FS.ts b/standalone-packages/codesandbox-browserfs/src/backend/HTML5FS.ts
@@ -179,7 +179,7 @@ export default class HTML5FS extends BaseFileSystem implements IFileSystem {
     fs._allocate((e) => e ? cb(e) : cb(null, fs));
   }
   public static isAvailable(): boolean {
-    return !!_getFS;
+    return Boolean(_getFS);
   }
 
   // HTML5File reaches into HTML5FS. :/
diff --git a/standalone-packages/codesandbox-browserfs/src/backend/IsoFS.ts b/standalone-packages/codesandbox-browserfs/src/backend/IsoFS.ts
@@ -432,7 +432,7 @@ abstract class DirectoryRecord {
     }
   }
   public isDirectory(isoData: Buffer): boolean {
-    let rv = !!(this.fileFlags() & FileFlags.Directory);
+    let rv = Boolean(this.fileFlags() && FileFlags.Directory);
     // If it lacks the Directory flag, it may still be a directory if we've exceeded the directory
     // depth limit. Rock Ridge marks these as files and adds a special attribute.
     if (!rv && this.hasRockRidge()) {
@@ -1030,7 +1030,7 @@ class TFEntry extends SystemUseEntry {
     }
   }
   private _longFormDates(): boolean {
-    return !!(this.flags() && TFFlags.LONG_FORM);
+    return Boolean(this.flags() && TFFlags.LONG_FORM);
   }
 }
 
diff --git a/standalone-packages/codesandbox-browserfs/src/core/util.ts b/standalone-packages/codesandbox-browserfs/src/core/util.ts
@@ -19,7 +19,7 @@ export function deprecationMessage(print: boolean, fsName: string, opts: any): v
  * userAgent string.
  * @hidden
  */
-export const isIE: boolean = typeof navigator !== "undefined" && !!(/(msie) ([\w.]+)/.exec(navigator.userAgent.toLowerCase()) || navigator.userAgent.indexOf('Trident') !== -1);
+export const isIE: boolean = typeof navigator !== "undefined" && Boolean(/(msie) ([\w.]+)/.exec(navigator.userAgent.toLowerCase()) || navigator.userAgent.indexOf('Trident') !== -1);
 
 /**
  * Check if we're in a web worker.
diff --git a/standalone-packages/codesandbox-browserfs/src/generic/file_index.ts b/standalone-packages/codesandbox-browserfs/src/generic/file_index.ts
@@ -367,12 +367,12 @@ export class DirInode<T> implements Inode {
  * @hidden
  */
 export function isFileInode<T>(inode: Inode | null): inode is FileInode<T> {
-  return !!inode && inode.isFile();
+  return Boolean(inode) && inode.isFile();
 }
 
 /**
  * @hidden
  */
 export function isDirInode<T>(inode: Inode | null): inode is DirInode<T> {
-  return !!inode && inode.isDir();
+  return Boolean(inode) && inode.isDir();
 }
diff --git a/standalone-packages/codesandbox-browserfs/test/tests/fs/HTTPRequest/listing.ts b/standalone-packages/codesandbox-browserfs/test/tests/fs/HTTPRequest/listing.ts
@@ -55,7 +55,7 @@ export default function() {
       });
 
       fs.stat("/src/not-existing-name", function(err, stats) {
-        assert(!!err, "Non existing file should return an error");
+        assert(Boolean(err), "Non existing file should return an error");
       });
 
     });
diff --git a/standalone-packages/codesandbox-browserfs/test/tests/fs/OverlayFS/error-test.ts b/standalone-packages/codesandbox-browserfs/test/tests/fs/OverlayFS/error-test.ts
@@ -23,7 +23,7 @@ export default function() {
 
   try {
     fs.readdir('/', function(err) {
-      assert(!!err, 'OverlayFS should pass an exception to its callback if it is not initialized.');
+      assert(Boolean(err), 'OverlayFS should pass an exception to its callback if it is not initialized.');
     });
   } catch (e) {
     assert(false, 'OverlayFS should never *throw* an exception on an asynchronous API call.');
@@ -33,4 +33,4 @@ export default function() {
     // Restore saved file system.
     fs.initialize(rootFS);
   });
-};
+};
diff --git a/standalone-packages/codesandbox-browserfs/test/tests/fs/all/rmdir.ts b/standalone-packages/codesandbox-browserfs/test/tests/fs/all/rmdir.ts
@@ -10,7 +10,7 @@ export default function() {
       fs.mkdir('/rmdirTest/rmdirTest2', function(e: NodeJS.ErrnoException) {
         assert(!e);
         fs.rmdir('/rmdirTest', function(e) {
-          assert(!!e, "Invariant failed: Successfully removed a non-empty directory.");
+          assert(Boolean(e), "Invariant failed: Successfully removed a non-empty directory.");
           assert(e.code === "ENOTEMPTY");
         });
       });
diff --git a/standalone-packages/codesandbox-browserfs/test/tests/general/check-options-test.ts b/standalone-packages/codesandbox-browserfs/test/tests/general/check-options-test.ts
@@ -34,7 +34,7 @@ function errorMessageAssert(expectedMsgs: string[], unexpectedMsgs: string[] = [
   return (e?: ApiError) => {
     assert(called === false, `Callback called twice!`);
     called = true;
-    assert(!!e, `Did not receive planned error message.`);
+    assert(Boolean(e), `Did not receive planned error message.`);
     const errorMessage = e.message;
     for (const m of expectedMsgs) {
       assert(errorMessage.indexOf(m) !== -1, `Error message '${errorMessage}' is missing expected string '${m}'.`);
diff --git a/standalone-packages/monaco-typescript/src/tsWorker.ts b/standalone-packages/monaco-typescript/src/tsWorker.ts
@@ -123,7 +123,7 @@ export class TypeScriptWorker implements ts.LanguageServiceHost {
     const ensureDirectoryExistence = (filePath, cb) => {
       const dirname = BrowserFS.BFSRequire("path").dirname(filePath);
       this.fs.stat(dirname, (err, exists) => {
-        if (!!exists) {
+        if (Boolean(exists)) {
           cb(true);
           return;
         }

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ export default {`
`142`	`142`
`143`	`143`	`fs.stat('/sandbox/tsconfig.json', (err, result) => {`
`144`	`144`	`// If tsconfig exists we want to sync the types`
`145`		`- syncDependencyTypings(rv.toString(), !!err \|\| !result);`
	`145`	`+ syncDependencyTypings(rv.toString(), Boolean(err) \|\| !result);`
`146`	`146`	`});`
`147`	`147`	`});`
`148`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export default class WorkspaceItem extends React.Component<Props, State> {`
`27`	`27`	`constructor(props: Props) {`
`28`	`28`	`super(props);`
`29`	`29`	`this.state = {`
`30`		`- open: !!props.defaultOpen,`
	`30`	`+ open: Boolean(props.defaultOpen),`
`31`	`31`	`};`
`32`	`32`	`}`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ export default Provider({`
`141`	`141`
`142`	`142`	`fs.stat('/sandbox/tsconfig.json', (err, result) => {`
`143`	`143`	`// If tsconfig exists we want to sync the types`
`144`		`- syncDependencyTypings(rv.toString(), !!err \|\| !result);`
	`144`	`+ syncDependencyTypings(rv.toString(), Boolean(err) \|\| !result);`
`145`	`145`	`});`
`146`	`146`	`});`
`147`	`147`	`}`