Skip to content

Commit 4f5f7f3

Browse files
author
Ives van Hoorne
committed
Fix feedback
1 parent caceeba commit 4f5f7f3

File tree

3 files changed

+70
-65
lines changed

3 files changed

+70
-65
lines changed

src/app/pages/Sandbox/Editor/Content/Header/FeedbackView.js

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,14 @@ type Props = {
5353
export default class FeedbackView extends React.PureComponent {
5454
props: Props;
5555
state = {
56-
open: false,
5756
message: '',
5857
};
5958

6059
handleChange = e => this.setState({ message: e.target.value });
6160

62-
handleSend = () => {
61+
handleSend = toggle => () => {
6362
if (this.state.message !== '') {
64-
this.toggle();
63+
toggle();
6564
this.props.sendMessage(this.state.message);
6665
this.setState({ message: '' });
6766
}
@@ -77,16 +76,18 @@ export default class FeedbackView extends React.PureComponent {
7776
Icon: FeedbackIcon,
7877
}}
7978
>
80-
<MessageView>
81-
<h3>Send feedback</h3>
82-
<textarea
83-
rows="5"
84-
value={this.state.message}
85-
placeholder="Ideas? Feedback? Thoughts? We'd love to hear them all!"
86-
onChange={this.handleChange}
87-
/>
88-
<Button onClick={this.handleSend}>Send</Button>
89-
</MessageView>
79+
{toggle => (
80+
<MessageView>
81+
<h3>Send feedback</h3>
82+
<textarea
83+
rows="5"
84+
value={this.state.message}
85+
placeholder="Ideas? Feedback? Thoughts? We'd love to hear them all!"
86+
onChange={this.handleChange}
87+
/>
88+
<Button onClick={this.handleSend(toggle)}>Send</Button>
89+
</MessageView>
90+
)}
9091
</HoverMenu>
9192
</Container>
9293
);

src/app/pages/Sandbox/Editor/Content/Header/HoverMenu.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,10 @@ export default class HoverMenu extends React.PureComponent {
5050
}
5151

5252
toggle = e => {
53-
e.stopPropagation();
54-
e.preventDefault();
53+
if (e) {
54+
e.stopPropagation();
55+
e.preventDefault();
56+
}
5557
this.setState({ open: !this.state.open });
5658
};
5759

@@ -62,7 +64,7 @@ export default class HoverMenu extends React.PureComponent {
6264
<span>
6365
<HeaderComponent {...headerProps} onClick={this.toggle} />
6466
<div ref={this.setOnclickListener}>
65-
{open && children}
67+
{open && children(this.toggle)}
6668
</div>
6769
</span>
6870
);

src/app/pages/Sandbox/Editor/Content/Header/ShareView.js

Lines changed: 51 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -182,58 +182,60 @@ export default class ShareView extends React.PureComponent {
182182
Icon: ShareIcon,
183183
}}
184184
>
185-
<ShareOptions>
186-
<h3>Share options</h3>
187-
<Divider>
188-
<Column>
189-
<div>
190-
<h4>Default view</h4>
191-
<div
192-
style={{
193-
position: 'relative',
194-
height: '2rem',
195-
width: '200px',
196-
marginLeft: '-10px',
197-
}}
198-
>
199-
<ModeIcons
200-
showEditor={showEditor}
201-
showPreview={showPreview}
202-
setEditorView={this.setEditorView}
203-
setPreviewView={this.setPreviewView}
204-
setMixedView={this.setMixedView}
185+
{() => (
186+
<ShareOptions>
187+
<h3>Share options</h3>
188+
<Divider>
189+
<Column>
190+
<div>
191+
<h4>Default view</h4>
192+
<div
193+
style={{
194+
position: 'relative',
195+
height: '2rem',
196+
width: '200px',
197+
marginLeft: '-10px',
198+
}}
199+
>
200+
<ModeIcons
201+
showEditor={showEditor}
202+
showPreview={showPreview}
203+
setEditorView={this.setEditorView}
204+
setPreviewView={this.setPreviewView}
205+
setMixedView={this.setMixedView}
206+
/>
207+
</div>
208+
</div>
209+
<div>
210+
<h4>Default module</h4>
211+
212+
<Files
213+
modules={sandbox.modules}
214+
directories={sandbox.directories}
215+
directoryId={null}
216+
currentModule={defaultModule}
217+
setCurrentModule={this.setDefaultModule}
205218
/>
206219
</div>
207-
</div>
208-
<div>
209-
<h4>Default module</h4>
210-
211-
<Files
212-
modules={sandbox.modules}
213-
directories={sandbox.directories}
214-
directoryId={null}
215-
currentModule={defaultModule}
216-
setCurrentModule={this.setDefaultModule}
217-
/>
218-
</div>
219-
</Column>
220-
<Column>
221-
<Inputs>
222-
<LinkName>Editor url</LinkName>
223-
<input onFocus={this.select} value={this.getEditorUrl()} />
224-
<LinkName>Fullscreen url</LinkName>
225-
<input onFocus={this.select} value={this.getEmbedUrl()} />
226-
{/*<LinkName>Embed url (Medium/Embedly)</LinkName>
220+
</Column>
221+
<Column>
222+
<Inputs>
223+
<LinkName>Editor url</LinkName>
224+
<input onFocus={this.select} value={this.getEditorUrl()} />
225+
<LinkName>Fullscreen url</LinkName>
226+
<input onFocus={this.select} value={this.getEmbedUrl()} />
227+
{/*<LinkName>Embed url (Medium/Embedly)</LinkName>
227228
<input onFocus={this.select} value={this.getEmbedUrl()} />*/}
228-
<LinkName>iframe</LinkName>
229-
<textarea
230-
onFocus={this.select}
231-
value={this.getIframeScript()}
232-
/>
233-
</Inputs>
234-
</Column>
235-
</Divider>
236-
</ShareOptions>
229+
<LinkName>iframe</LinkName>
230+
<textarea
231+
onFocus={this.select}
232+
value={this.getIframeScript()}
233+
/>
234+
</Inputs>
235+
</Column>
236+
</Divider>
237+
</ShareOptions>
238+
)}
237239
</HoverMenu>
238240
</Container>
239241
);

0 commit comments

Comments
 (0)