Skip to content

Commit 4e82c2e

Browse files
committed
Make overlay close on keydown instead
1 parent e16f90e commit 4e82c2e

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

packages/app/src/app/components/Overlay/Overlay.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,16 @@ export const Overlay: React.FC<IOverlayProps> = ({
9191
}
9292
};
9393

94-
document.addEventListener('keypress', handleEscape);
94+
if (openState) {
95+
document.addEventListener('keydown', handleEscape);
96+
} else {
97+
document.removeEventListener('keydown', handleEscape);
98+
}
9599

96100
return () => {
97-
document.removeEventListener('keypress', handleEscape);
101+
document.removeEventListener('keydown', handleEscape);
98102
};
99-
}, [handleClose]);
103+
}, [handleClose, openState]);
100104

101105
const handleOpen = () => {
102106
if (event) {

0 commit comments

Comments
 (0)