Skip to content

Commit 49c2083

Browse files
author
Ives van Hoorne
committed
Cleanup
1 parent af1893f commit 49c2083

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/app/src/sandbox/eval/manager.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ export default class Manager {
8787
this.preset = preset;
8888
this.transpiledModules = {};
8989
this.cachedPaths = {};
90-
this.dirtyModules = new Set();
9190
this.transpileJobs = {};
9291
modules.forEach(m => this.addModule(m));
9392

packages/app/src/sandbox/eval/transpiled-module.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export default class TranspiledModule {
161161

162162
dispose(manager: Manager) {
163163
if (this.hmrConfig) {
164-
// If this is a hot module we hot reload the application, same as Webpack v2.
164+
// If this is a hot module we fully reload the application, same as Webpack v2.
165165
manager.markHardReload();
166166
}
167167

@@ -684,8 +684,8 @@ export default class TranspiledModule {
684684
!this.isEntry
685685
) {
686686
// Remove the module from the transpiler if it's not used anymore
687-
debug(`Removing '${this.getId()} from manager.`);
688-
// this.dispose(manager);
687+
debug(`Removing '${this.getId()}' from manager.`);
688+
this.dispose(manager);
689689
}
690690
}
691691

0 commit comments

Comments
 (0)