Skip to content

Commit 401205c

Browse files
jseminckCompuIves
authored andcommitted
Add development support for people on Windows (codesandbox#132)
* Add development support for people on Windows * Add @jseminck as a contributor * Update @jseminck as a contributor * Update @jseminck as a contributor
1 parent 7881a83 commit 401205c

File tree

4 files changed

+24
-5
lines changed

4 files changed

+24
-5
lines changed

.all-contributorsrc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,15 @@
9191
"code"
9292
]
9393
},
94+
{
95+
"login": "jseminck",
96+
"name": "Joachim Seminck",
97+
"avatar_url": "https://avatars2.githubusercontent.com/u/9586897?v=4",
98+
"profile": "https://github.com/jseminck",
99+
"contributions": [
100+
"code"
101+
]
102+
},
94103
{
95104
"login": "chakrihacker",
96105
"name": "Subramanya Chakravarthy",

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds
4646
<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
4747
| [<img src="https://avatars0.githubusercontent.com/u/587016?v=3" width="100px;"/><br /><sub>Ives van Hoorne</sub>](http://ivesvh.com)<br />[💬](#question-CompuIves "Answering Questions") [📝](#blog-CompuIves "Blogposts") [🐛](https://github.com/CompuIves/CodeSandbox/issues?q=author%3ACompuIves "Bug reports") [💻](https://github.com/CompuIves/CodeSandbox/commits?author=CompuIves "Code") [🎨](#design-CompuIves "Design") [📖](https://github.com/CompuIves/CodeSandbox/commits?author=CompuIves "Documentation") [💡](#example-CompuIves "Examples") [🚇](#infra-CompuIves "Infrastructure (Hosting, Build-Tools, etc)") [👀](#review-CompuIves "Reviewed Pull Requests") [⚠️](https://github.com/CompuIves/CodeSandbox/commits?author=CompuIves "Tests") [🔧](#tool-CompuIves "Tools") | [<img src="https://avatars0.githubusercontent.com/u/887639?v=3" width="100px;"/><br /><sub>Donavon West</sub>](http://donavon.com)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=donavon "Code") | [<img src="https://avatars0.githubusercontent.com/u/5266810?v=3" width="100px;"/><br /><sub>Jeff Allen</sub>](http://www.jeffallen.io/)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=vueu "Code") | [<img src="https://avatars0.githubusercontent.com/u/1089897?v=3" width="100px;"/><br /><sub>Ben Gummer</sub>](https://github.com/bengummer)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=bengummer "Code") | [<img src="https://avatars3.githubusercontent.com/u/154732?v=3" width="100px;"/><br /><sub>James Gillmore</sub>](http://twitter.com/faceyspacey)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=faceyspacey "Code") [🐛](https://github.com/CompuIves/CodeSandbox/issues?q=author%3Afaceyspacey "Bug reports") | [<img src="https://avatars1.githubusercontent.com/u/9636410?v=4" width="100px;"/><br /><sub>Ade Viankakrisna Fadlil</sub>](https://musify.id)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=viankakrisna "Code") | [<img src="https://avatars1.githubusercontent.com/u/1854763?v=4" width="100px;"/><br /><sub>Tushar Sonawane</sub>](https://twitter.com/tushkiz)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=Tushkiz "Code") |
4848
| :---: | :---: | :---: | :---: | :---: | :---: | :---: |
49-
| [<img src="https://avatars3.githubusercontent.com/u/1239401?v=4" width="100px;"/><br /><sub>Johann Hubert Sonntagbauer</sub>](https://github.com/johann-sonntagbauer)<br />[🐛](https://github.com/CompuIves/CodeSandbox/issues?q=author%3Ajohann-sonntagbauer "Bug reports") [💻](https://github.com/CompuIves/CodeSandbox/commits?author=johann-sonntagbauer "Code") | [<img src="https://avatars3.githubusercontent.com/u/5210019?v=4" width="100px;"/><br /><sub>Subramanya Chakravarthy</sub>](http://chakrihacker.github.io)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=chakrihacker "Code") |
49+
| [<img src="https://avatars3.githubusercontent.com/u/1239401?v=4" width="100px;"/><br /><sub>Johann Hubert Sonntagbauer</sub>](https://github.com/johann-sonntagbauer)<br />[🐛](https://github.com/CompuIves/CodeSandbox/issues?q=author%3Ajohann-sonntagbauer "Bug reports") [💻](https://github.com/CompuIves/CodeSandbox/commits?author=johann-sonntagbauer "Code") | [<img src="https://avatars3.githubusercontent.com/u/5210019?v=4" width="100px;"/><br /><sub>Subramanya Chakravarthy</sub>](http://chakrihacker.github.io)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=chakrihacker "Code") | [<img src="https://avatars2.githubusercontent.com/u/9586897?v=4" width="100px;"/><br /><sub>Joachim Seminck</sub>](https://github.com/jseminck)<br />[💻](https://github.com/CompuIves/CodeSandbox/commits?author=jseminck "Code")
5050
<!-- ALL-CONTRIBUTORS-LIST:END -->
5151

5252
This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. Contributions of any kind welcome!

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"chalk": "1.1.3",
2626
"connect-history-api-fallback": "1.3.0",
2727
"copy-webpack-plugin": "^4.0.1",
28+
"cross-env": "^5.0.5",
2829
"cross-spawn": "^5.0.1",
2930
"css-loader": "^0.28.1",
3031
"detect-port": "^1.1.1",
@@ -140,9 +141,9 @@
140141
"tern": "^0.21.0"
141142
},
142143
"scripts": {
143-
"start": "LOCAL_SERVER=1 node scripts/start.js",
144+
"start": "cross-env LOCAL_SERVER=1 node scripts/start.js",
144145
"start:dev_api": "node scripts/start.js",
145-
"build": "NODE_ENV=production node scripts/build.js && gulp",
146+
"build": "cross-env NODE_ENV=production node scripts/build.js && gulp",
146147
"test": "jest --env=jsdom",
147148
"test:watch": "jest --watch --env=jsdom",
148149
"lint:app": "eslint src/app && npm run typecheck",

yarn.lock

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2214,7 +2214,14 @@ [email protected], create-react-class@^15.6.0:
22142214
loose-envify "^1.3.1"
22152215
object-assign "^4.1.1"
22162216

2217-
[email protected], cross-spawn@^5.0.1:
2217+
cross-env@^5.0.5:
2218+
version "5.0.5"
2219+
resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-5.0.5.tgz#4383d364d9660873dd185b398af3bfef5efffef3"
2220+
dependencies:
2221+
cross-spawn "^5.1.0"
2222+
is-windows "^1.0.0"
2223+
2224+
[email protected], cross-spawn@^5.0.1, cross-spawn@^5.1.0:
22182225
version "5.1.0"
22192226
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-5.1.0.tgz#e8bd0efee58fcff6f8f94510a0a554bbfa235449"
22202227
dependencies:
@@ -4556,7 +4563,7 @@ is-windows@^0.2.0:
45564563
version "0.2.0"
45574564
resolved "https://registry.yarnpkg.com/is-windows/-/is-windows-0.2.0.tgz#de1aa6d63ea29dd248737b69f1ff8b8002d2108c"
45584565

4559-
is-windows@^1.0.1:
4566+
is-windows@^1.0.0, is-windows@^1.0.1:
45604567
version "1.0.1"
45614568
resolved "https://registry.yarnpkg.com/is-windows/-/is-windows-1.0.1.tgz#310db70f742d259a16a369202b51af84233310d9"
45624569

@@ -5652,6 +5659,8 @@ moment@^2.18.1:
56525659
monaco-editor@CompuIves/codesandbox-monaco-editor:
56535660
version "0.9.0"
56545661
resolved "https://codeload.github.com/CompuIves/codesandbox-monaco-editor/tar.gz/e4e1efb582934ffd8fb135b1cfa1af82cdbc85e3"
5662+
dependencies:
5663+
monaco-typescript CompuIves/monaco-typescript
56555664

56565665
56575666
version "2.0.0"

0 commit comments

Comments
 (0)