Always dispatch errors for puppeteer

Ives van Hoorne · Ives van Hoorne · commit 3fab018fdd7d · 2018-01-03T21:26:24.000+01:00
diff --git a/packages/app/src/sandbox/compile.js b/packages/app/src/sandbox/compile.js
@@ -162,10 +162,6 @@ async function compile({
       initializeResizeListener();
     }
 
-    if (typeof window.__puppeteer__ === 'function') {
-      window.__puppeteer__('done');
-    }
-
     dispatch({
       type: 'success',
     });
@@ -181,6 +177,10 @@ async function compile({
 
     window.dispatchEvent(event);
   }
+
+  if (typeof window.__puppeteer__ === 'function') {
+    window.__puppeteer__('done');
+  }
 }
 
 type Arguments = {

Original file line number	Diff line number	Diff line change
`@@ -162,10 +162,6 @@ async function compile({`
`162`	`162`	`initializeResizeListener();`
`163`	`163`	`}`
`164`	`164`
`165`		`- if (typeof window.__puppeteer__ === 'function') {`
`166`		`- window.__puppeteer__('done');`
`167`		`- }`
`168`		`-`
`169`	`165`	`dispatch({`
`170`	`166`	`type: 'success',`
`171`	`167`	`});`
`@@ -181,6 +177,10 @@ async function compile({`
`181`	`177`
`182`	`178`	`window.dispatchEvent(event);`
`183`	`179`	`}`
	`180`	`+`
	`181`	`+ if (typeof window.__puppeteer__ === 'function') {`
	`182`	`+ window.__puppeteer__('done');`
	`183`	`+ }`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`type Arguments = {`