Refactor GraphQL Result Param Reassignment (codesandbox#1890)

Instead of reassigning values on the result object, which previously required disabling eslint, this refactor uses ES6 object destructuring  and rest/spread to create a new result object.

Author: Saeris

packages/app/src/app/graphql/client.js

@@ -24,14 +24,11 @@ const authLink = setContext((_, { headers }) => {
 });
 
 const absintheAfterware = new ApolloLink((operation, forward) =>
-  forward(operation).map(result => {
-    /* eslint-disable no-param-reassign */
-    result.errors = result.payload.errors;
-    result.data = result.payload.data;
-    /* eslint-enable */
-
-    return result;
-  })
+  forward(operation).map(({ payload, ...result }) => ({
+    ...result,
+    errors: payload.errors,
+    data: payload.data
+  }))
 );
 
 const errorHandler = onError(({ graphQLErrors, networkError }) => {