Skip to content

Commit 39feca6

Browse files
committed
Fix dependencies with spaces in their version
1 parent ec96d62 commit 39feca6

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

packages/app/src/sandbox/npm/fetch-dependencies.js

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,19 @@ function dependenciesToBucketPath(dependencies: Object) {
9090
.join('%2B')}.json`;
9191
}
9292

93+
/**
94+
* Some dependencies have a space in their version for some reason, this is invalid and we
95+
* ignore them. This is what yarn does as well.
96+
*/
97+
function removeSpacesFromDependencies(dependencies: Object) {
98+
const newDeps = {};
99+
Object.keys(dependencies).forEach(depName => {
100+
const [version] = dependencies[depName].split(' ');
101+
newDeps[depName] = version;
102+
});
103+
return newDeps;
104+
}
105+
93106
async function getAbsoluteDependencies(dependencies: Object) {
94107
const nonAbsoluteDependencies = Object.keys(dependencies).filter(dep => {
95108
const version = dependencies[dep];
@@ -124,7 +137,9 @@ async function getAbsoluteDependencies(dependencies: Object) {
124137
}
125138

126139
async function getDependencies(dependencies: Object) {
127-
const absoluteDependencies = await getAbsoluteDependencies(dependencies);
140+
const absoluteDependencies = await getAbsoluteDependencies(
141+
removeSpacesFromDependencies(dependencies)
142+
);
128143
const dependencyUrl = dependenciesToQuery(absoluteDependencies);
129144
const bucketDependencyUrl = dependenciesToBucketPath(absoluteDependencies);
130145

0 commit comments

Comments
 (0)