Fix issue when clicking prettify when the sandbox contains syntax errors (codesandbox#186)

jseminck · CompuIves · commit 3956ffec9067 · 2017-09-06T00:01:10.000+02:00
* Check that newCode is actually defined before switching the output

* Remove console log

* Fix prettier
diff --git a/src/app/components/sandbox/CodeEditor/CodeMirror.js b/src/app/components/sandbox/CodeEditor/CodeMirror.js
@@ -442,7 +442,7 @@ export default class CodeEditor extends React.PureComponent<Props, State> {
           preferences.prettierConfig
         );
 
-        if (newCode !== code) {
+        if (newCode && newCode !== code) {
           this.props.changeCode(id, newCode);
           this.updateCodeMirrorCode(newCode);
         }
diff --git a/src/app/components/sandbox/CodeEditor/Monaco.js b/src/app/components/sandbox/CodeEditor/Monaco.js
@@ -736,7 +736,7 @@ export default class CodeEditor extends React.PureComponent<Props, State> {
           preferences.prettierConfig
         );
 
-        if (newCode !== code) {
+        if (newCode && newCode !== code) {
           this.props.changeCode(id, newCode);
           this.updateCode(newCode);
         }

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ export default class CodeEditor extends React.PureComponent<Props, State> {`
`442`	`442`	`preferences.prettierConfig`
`443`	`443`	`);`
`444`	`444`
`445`		`- if (newCode !== code) {`
	`445`	`+ if (newCode && newCode !== code) {`
`446`	`446`	`this.props.changeCode(id, newCode);`
`447`	`447`	`this.updateCodeMirrorCode(newCode);`
`448`	`448`	`}`
Original file line number	Diff line number	Diff line change
`@@ -736,7 +736,7 @@ export default class CodeEditor extends React.PureComponent<Props, State> {`
`736`	`736`	`preferences.prettierConfig`
`737`	`737`	`);`
`738`	`738`
`739`		`- if (newCode !== code) {`
	`739`	`+ if (newCode && newCode !== code) {`
`740`	`740`	`this.props.changeCode(id, newCode);`
`741`	`741`	`this.updateCode(newCode);`
`742`	`742`	`}`