fix issue, also in production, deleting directories with files

Author: christianalfoni

packages/app/src/app/overmind/namespaces/editor/actions.ts

@@ -300,9 +300,10 @@ export const likeSandboxToggled: AsyncAction<{
   state.editor.sandboxes[id].userLiked = !state.editor.sandboxes[id].userLiked;
 };
 
-// This might be called from explorer or vscode
 export const moduleSelected: Action<{
+  // Path means it is coming from VSCode
   path?: string;
+  // Id means it is coming from Explorer
   id?: string;
 }> = ({ state, effects, actions }, { path, id }) => {
   effects.analytics.track('Open File');
@@ -358,7 +359,8 @@ export const moduleSelected: Action<{
       effects.live.sendUserCurrentModule(module.shortid);
     }
   } catch (error) {
-    state.editor.currentModuleShortid = null;
+    // Do nothing, it is most likely VSCode selecting a file
+    // that is deleted... yeah... it does that
   }
 };
 

packages/app/src/app/overmind/namespaces/files/actions.ts

@@ -214,7 +214,12 @@ export const directoryDeleted: AsyncAction<{
   )[0];
 
   state.editor.currentModuleShortid = state.editor.mainModule.shortid;
-  effects.vscode.fs.rmdir(state.editor.modulesByPath, removedDirectory);
+
+  // we need to recreate everything, as you might have deleted any number
+  // of nested directories or files
+  state.editor.modulesByPath = effects.vscode.fs.create(sandbox);
+  effects.vscode.openModule(state.editor.currentModule);
+
   try {
     await effects.api.deleteDirectory(state.editor.currentId, directoryShortid);
     effects.live.sendDirectoryDeleted(directoryShortid);