rename to syncModule and avoid sending operation (codesandbox#3774)

* rename to syncModule and avoid sending operation

* Apply suggestions from code review

Co-authored-by: Ives van Hoorne <[email protected]>

Author: christianalfoni

packages/app/src/app/overmind/effects/vscode/ModelsHandler.ts

@@ -101,7 +101,7 @@ export class ModelsHandler {
     return null;
   }
 
-  public async revertModule(module: Module) {
+  public async syncModule(module: Module) {
     const fileModel = this.editorApi.textFileService
       .getFileModels()
       .find(
@@ -110,7 +110,9 @@ export class ModelsHandler {
       );
 
     if (fileModel) {
+      this.isApplyingOperation = true;
       fileModel.revert();
+      this.isApplyingOperation = false;
     }
   }
 

packages/app/src/app/overmind/effects/vscode/index.ts

@@ -317,8 +317,8 @@ export class VSCodeEffect {
     }
   }
 
-  public revertModule(module: Module) {
-    this.modelsHandler.revertModule(module);
+  public syncModule(module: Module) {
+    this.modelsHandler.syncModule(module);
   }
 
   public async applyOperation(

packages/app/src/app/overmind/namespaces/editor/actions.ts

@@ -329,7 +329,7 @@ export const onOperationApplied: Action<{
   actions.editor.internal.updatePreviewCode();
 
   if (module.savedCode !== null && module.code === module.savedCode) {
-    effects.vscode.revertModule(module);
+    effects.vscode.syncModule(module);
   }
 };
 
@@ -394,7 +394,7 @@ export const codeChanged: Action<{
     code,
   });
   if (module.savedCode !== null && module.code === module.savedCode) {
-    effects.vscode.revertModule(module);
+    effects.vscode.syncModule(module);
   }
 
   const { isServer } = getTemplate(state.editor.currentSandbox.template);
@@ -734,7 +734,7 @@ export const discardModuleChanges: Action<{
   }
 
   module.updatedAt = new Date().toString();
-  effects.vscode.revertModule(module);
+  effects.vscode.syncModule(module);
 };
 
 export const fetchEnvironmentVariables: AsyncAction = async ({

packages/app/src/app/overmind/namespaces/live/internalActions.ts

@@ -141,7 +141,7 @@ export const initializeModuleState: Action<IModuleState> = (
           );
         }
         if (moduleInfo.synced) {
-          effects.vscode.revertModule(module);
+          effects.vscode.syncModule(module);
         } else {
           effects.vscode.setModuleCode(module);
         }

packages/app/src/app/overmind/namespaces/live/liveMessageOperators.ts

@@ -181,7 +181,7 @@ export const onModuleSaved: Operator<LiveMessage<{
 
     effects.vscode.sandboxFsSync.writeFile(state.editor.modulesByPath, module);
     // We revert the module so that VSCode will flag saved indication correctly
-    effects.vscode.revertModule(module);
+    effects.vscode.syncModule(module);
     actions.editor.internal.updatePreviewCode();
   }
 });