Skip to content

Commit 2acdfce

Browse files
committed
Fix showing sandbox not found
1 parent 6e48f0c commit 2acdfce

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

packages/app/src/app/overmind/namespaces/editor/actions.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ export const sandboxChanged: AsyncAction<{ id: string }> = withLoadApp<{
106106
} catch (error) {
107107
state.editor.notFound = true;
108108
state.editor.error = error.message;
109+
state.editor.isLoading = false;
110+
return;
109111
}
110112

111113
const sandbox = state.editor.currentSandbox;

packages/app/src/app/pages/Sandbox/index.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,10 @@ class SandboxPage extends React.Component {
6161

6262
const { hasLogIn } = store;
6363

64-
if (store.editor.notFound) {
65-
return <NotFound />;
66-
}
67-
6864
if (store.editor.error) {
6965
const isGithub = this.props.match.params.id.includes('github');
7066
const hasPrivateAccess = store.user && store.user.integrations.github;
67+
7168
return (
7269
<>
7370
<div
@@ -115,6 +112,10 @@ class SandboxPage extends React.Component {
115112
);
116113
}
117114

115+
if (store.editor.notFound) {
116+
return <NotFound />;
117+
}
118+
118119
if (
119120
store.editor.isLoading ||
120121
(store.live.isTeam && store.live.isLoading) ||

0 commit comments

Comments
 (0)