Skip to content

Commit 299c273

Browse files
zpluspUser
authored andcommitted
🔨 Refactor, 🧠 Overmind Hactoberfest | Refactor app/pages/comm… (codesandbox#2841)
Co-authored-by: User <[email protected]>
1 parent cf3314e commit 299c273

File tree

1 file changed

+19
-16
lines changed
  • packages/app/src/app/pages/common/Modals/PreferencesModal/EditorPageSettings/EditorSettings

1 file changed

+19
-16
lines changed

packages/app/src/app/pages/common/Modals/PreferencesModal/EditorPageSettings/EditorSettings/index.js renamed to packages/app/src/app/pages/common/Modals/PreferencesModal/EditorPageSettings/EditorSettings/index.tsx

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import { inject, observer } from 'app/componentConnectors';
2+
import { useOvermind } from 'app/overmind';
33

44
import {
55
Title,
@@ -11,17 +11,24 @@ import {
1111
} from '../../elements';
1212
import VSCodePlaceholder from '../../VSCodePlaceholder';
1313

14-
const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
15-
const isFF = navigator.userAgent.toLowerCase().includes('firefox');
14+
const isSafari: boolean = /^((?!chrome|android).)*safari/i.test(
15+
navigator.userAgent
16+
);
17+
const isFF: boolean = navigator.userAgent.toLowerCase().includes('firefox');
18+
19+
export const EditorSettings: React.FC = () => {
20+
const {
21+
state: {
22+
preferences: { settings },
23+
},
24+
actions: {
25+
preferences: { settingChanged },
26+
},
27+
} = useOvermind();
1628

17-
function EditorSettingsComponent({ store, signals }) {
18-
const bindValue = name => ({
19-
value: store.preferences.settings[name],
20-
setValue: value =>
21-
signals.preferences.settingChanged({
22-
name,
23-
value,
24-
}),
29+
const bindValue = (name: string) => ({
30+
value: settings[name],
31+
setValue: (value: any) => settingChanged({ name, value }),
2532
});
2633

2734
return (
@@ -97,8 +104,4 @@ function EditorSettingsComponent({ store, signals }) {
97104
</SubContainer>
98105
</div>
99106
);
100-
}
101-
102-
export const EditorSettings = inject('store', 'signals')(
103-
observer(EditorSettingsComponent)
104-
);
107+
};

0 commit comments

Comments
 (0)