Move version logic to production

Author: Ives van Hoorne

config/webpack.common.js

@@ -5,7 +5,6 @@ const HtmlWebpackPlugin = require('html-webpack-plugin');
 const CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin');
 const CopyWebpackPlugin = require('copy-webpack-plugin');
 const HappyPack = require('happypack');
-const childProcess = require('child_process');
 const WatchMissingNodeModulesPlugin = require('../scripts/utils/WatchMissingNodeModulesPlugin');
 const env = require('./env');
 
@@ -17,15 +16,6 @@ const __DEV__ = NODE_ENV === 'development'; // eslint-disable-line no-underscore
 const __PROD__ = NODE_ENV === 'production'; // eslint-disable-line no-underscore-dangle
 const babelConfig = __DEV__ ? babelDev : babelProd;
 
-const COMMIT_COUNT = childProcess
-  .execSync('git rev-list --count HEAD')
-  .toString();
-
-const COMMIT_HASH = childProcess
-  .execSync('git rev-parse --short HEAD')
-  .toString();
-const VERSION = `${COMMIT_COUNT}-${COMMIT_HASH}`;
-
 module.exports = {
   entry: {
     app: [require.resolve('./polyfills'), path.join(paths.appSrc, 'index.js')],
@@ -206,7 +196,6 @@ module.exports = {
     // Makes some environment variables available to the JS code, for example:
     // if (process.env.NODE_ENV === 'development') { ... }. See `env.js`.
     new webpack.DefinePlugin(env),
-    new webpack.DefinePlugin({ VERSION: JSON.stringify(VERSION) }),
     // Watcher doesn't work well if you mistype casing in a path so we use
     // a plugin that prints an error when you attempt to do this.
     // See https://github.com/facebookincubator/create-react-app/issues/240

config/webpack.prod.js

@@ -1,10 +1,20 @@
 const merge = require('webpack-merge');
 const webpack = require('webpack');
 const SWPrecacheWebpackPlugin = require('sw-precache-webpack-plugin');
+const childProcess = require('child_process');
 const commonConfig = require('./webpack.common');
 
 const publicPath = '/';
 
+const COMMIT_COUNT = childProcess
+  .execSync('git rev-list --count HEAD')
+  .toString();
+
+const COMMIT_HASH = childProcess
+  .execSync('git rev-parse --short HEAD')
+  .toString();
+const VERSION = `${COMMIT_COUNT}-${COMMIT_HASH}`;
+
 module.exports = merge(commonConfig, {
   devtool: 'source-map',
   output: {
@@ -13,6 +23,7 @@ module.exports = merge(commonConfig, {
     sourceMapFilename: '[file].map', // Default
   },
   plugins: [
+    new webpack.DefinePlugin({ VERSION: JSON.stringify(VERSION) }),
     new webpack.LoaderOptionsPlugin({
       minimize: true,
       debug: false,