Add more strict typing

Author: CompuIves

packages/app/src/app/index.js

@@ -37,6 +37,18 @@ import HTML5Backend from './pages/common/HTML5BackendWithFolderSupport';
 
 const debug = _debug('cs:app');
 
+/**
+ * Get rid of a tippy warning that spams the console, and doesn't seem valid.
+ */
+const warn = console.warn;
+console.warn = (...args) => {
+  if (args[0].includes('Cannot update plugins')) {
+    return;
+  }
+
+  warn(...args);
+};
+
 window.setImmediate = (func, delay) => setTimeout(func, delay);
 
 window.addEventListener('unhandledrejection', e => {

packages/app/src/app/overmind/namespaces/editor/state.ts

@@ -16,6 +16,7 @@ import {
   SandboxFs,
   Tabs,
   WindowOrientation,
+  Directory,
 } from '@codesandbox/common/lib/types';
 import { getSandboxOptions } from '@codesandbox/common/lib/url';
 import { CollaboratorFragment, InvitationFragment } from 'app/graphql/types';
@@ -278,7 +279,11 @@ export const state: State = {
 };
 
 // This should be moved somewhere else
-function getModuleParents(modules, directories, id): string[] {
+function getModuleParents(
+  modules: Module[],
+  directories: Directory[],
+  id: string
+): string[] {
   const module = modules.find(moduleEntry => moduleEntry.id === id);
 
   if (!module) return [];
@@ -288,9 +293,9 @@ function getModuleParents(modules, directories, id): string[] {
   );
   let directoryIds: string[] = [];
   while (directory != null) {
-    directoryIds = [...directoryIds, directory.id];
+    directoryIds = [...directoryIds, directory!.id];
     directory = directories.find(
-      directoryEntry => directoryEntry.shortid === directory.directoryShortid // eslint-disable-line
+      directoryEntry => directoryEntry.shortid === directory!.directoryShortid // eslint-disable-line
     );
   }
 

packages/app/src/app/overmind/namespaces/files/actions.ts

@@ -267,7 +267,7 @@ export const directoryMovedToDirectory: AsyncAction<{
 );
 
 export const directoryDeleted: AsyncAction<{
-  directoryShortid;
+  directoryShortid: string;
 }> = withOwnedSandbox(
   async ({ state, actions, effects }, { directoryShortid }) => {
     const sandbox = state.editor.currentSandbox;

packages/app/src/app/overmind/namespaces/files/internalActions.ts

@@ -76,7 +76,9 @@ export const uploadFiles: AsyncAction<
     directories: any;
   }
 > = async ({ effects }, { files, directoryShortid }) => {
-  const parsedFiles = {};
+  const parsedFiles: {
+    [key: string]: { isBinary: boolean; content: string };
+  } = {};
   // We first create chunks so we don't overload the server with 100 multiple
   // upload requests
   const filePaths = Object.keys(files);

packages/app/src/app/overmind/namespaces/live/state.ts

@@ -29,7 +29,7 @@ type State = {
   liveUsersByModule: Derive<
     State,
     {
-      [id: string]: string[];
+      [id: string]: number[][];
     }
   >;
 };
@@ -76,7 +76,7 @@ export const state: State = {
         currentState.roomInfo?.ownerIds.includes(currentState.liveUserId)
     ),
   liveUsersByModule: currentState => {
-    const usersByModule = {};
+    const usersByModule: { [id: string]: number[][] } = {};
 
     if (!currentState.isLive || !currentState.roomInfo) {
       return {};
@@ -86,7 +86,7 @@ export const state: State = {
 
     currentState.roomInfo.users.forEach(user => {
       const userId = user.id;
-      if (userId !== liveUserId && user.currentModuleShortid) {
+      if (user && userId !== liveUserId && user.currentModuleShortid) {
         usersByModule[user.currentModuleShortid] =
           usersByModule[user.currentModuleShortid] || [];
         usersByModule[user.currentModuleShortid].push(user.color);

packages/app/src/app/overmind/onInitialize.ts

@@ -87,9 +87,9 @@ export const onInitialize: OnInitialize = async (
     onViewRangeChanged: actions.live.onViewRangeChanged,
     onCommentClick: actions.comments.onCommentClick,
     reaction: overmindInstance.reaction,
-    getState: path =>
+    getState: (path: string) =>
       path ? path.split('.').reduce((aggr, key) => aggr[key], state) : state,
-    getSignal: path =>
+    getSignal: (path: string) =>
       path.split('.').reduce((aggr, key) => aggr[key], actions),
   });
 

packages/app/src/app/overmind/utils/common.ts

@@ -1,7 +1,7 @@
 import { Module } from '@codesandbox/common/lib/types';
 import { fromPairs, sortBy, toPairs } from 'lodash-es';
 
-export function sortObjectByKeys(object) {
+export function sortObjectByKeys(object: object) {
   return fromPairs(sortBy(toPairs(object)));
 }
 
@@ -25,7 +25,11 @@ export function createOptimisticModule(overrides: Partial<Module>) {
   };
 }
 
-export function lineAndColumnToIndex(lines, lineNumber, column) {
+export function lineAndColumnToIndex(
+  lines: string[],
+  lineNumber: number,
+  column: number
+) {
   let currentLine = 0;
   let index = 0;
 
@@ -40,7 +44,7 @@ export function lineAndColumnToIndex(lines, lineNumber, column) {
   return index;
 }
 
-export function indexToLineAndColumn(lines, index) {
+export function indexToLineAndColumn(lines: string[], index: number) {
   let offset = 0;
   for (let i = 0; i < lines.length; i++) {
     const line = lines[i];

packages/app/src/app/overmind/utils/event-to-transform.ts

@@ -3,10 +3,10 @@ import { TextOperation } from 'ot';
 import { lineAndColumnToIndex } from './common';
 
 export default function convertChangeEventToOperation(
-  changeEvent,
-  liveOperationCode
+  changeEvent: any,
+  liveOperationCode: string
 ) {
-  let otOperation;
+  let otOperation: TextOperation;
 
   let composedCode = liveOperationCode;
 
@@ -38,13 +38,13 @@ export default function convertChangeEventToOperation(
       newOt.retain(remaining);
     }
 
-    otOperation = otOperation ? otOperation.compose(newOt) : newOt;
+    otOperation = otOperation! ? otOperation!.compose(newOt) : newOt;
 
-    composedCode = otOperation.apply(liveOperationCode);
+    composedCode = otOperation!.apply(liveOperationCode);
   }
 
   return {
-    operation: otOperation,
+    operation: otOperation!,
     newCode: composedCode,
   };
 }

packages/app/src/app/overmind/utils/files.ts

@@ -4,7 +4,7 @@ import { Sandbox } from '@codesandbox/common/lib/types';
 
 import { resolveModuleWrapped } from './resolve-module-wrapped';
 
-export const getModuleCode = (sandbox: Sandbox, prettierConfig) => {
+export const getModuleCode = (sandbox: Sandbox, prettierConfig: unknown) => {
   const path = getModulePath(sandbox.modules, sandbox.directories, module.id);
   const template = getDefinition(sandbox.template);
   const config = template.configurationFiles[path];

packages/app/src/app/overmind/utils/pushToAirtable.ts

@@ -6,6 +6,8 @@ export default async ({
   email,
   version,
   browser,
+}: {
+  [key: string]: string;
 }) => {
   const Airtable = await import(
     /* webpackChunkName: 'airtable' */ './setAirtable'